feat: support distro "flavors"#31
Open
super-cooper wants to merge 2 commits intoDanielFGray:masterfrom
Open
Conversation
Owner
|
can you confirm this doesnt change behavior on other distros? |
Contributor
Author
|
Tested on arch, debian, void, and fedora containers. Worked on all except debian and fedora. I found that it selects the right distro, but does not execute the search query. I tested against the master branch and it doesn't work there either, so that seems worth an investigation. |
Contributor
Author
|
@DanielFGray would you prefer I do more testing? If so, please let me know what you're hoping to see |
Contributor
Author
|
@DanielFGray pinging again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed on my Manjaro machine that it would not pick up the distro "flavor" (arch) because the
NAMEfield in/etc/os-releasewas "Manjaro Linux".This patch modifies the
awkscript used to find the distro such that it will first attempt to use theID_LIKEfield to capture the "flavor", deferring toIDifID_LIKEis not set. Finally, it will defer toNAMEifIDis not set. This makes more sense to me, asNAMEis meant to be a human legible field, andIDandID_LIKEhave standardized formats. A future feature could be more complex parsing ofID_LIKE, but for now expecting a single value seems like it should be fine.Below I'm including descriptions of the described fields from
man os-releaseas justification for this change: