[crashtracker] Add command line option to pass the thread context#8244
Draft
[crashtracker] Add command line option to pass the thread context#8244
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8244) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8244) - mean (74ms) : 71, 76
master - mean (75ms) : 73, 77
section Bailout
This PR (8244) - mean (78ms) : 77, 80
master - mean (79ms) : 78, 81
section CallTarget+Inlining+NGEN
This PR (8244) - mean (1,070ms) : 1025, 1116
master - mean (1,089ms) : 1047, 1130
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8244) - mean (114ms) : 110, 118
master - mean (117ms) : 113, 120
section Bailout
This PR (8244) - mean (115ms) : 112, 118
master - mean (118ms) : 115, 121
section CallTarget+Inlining+NGEN
This PR (8244) - mean (769ms) : 713, 825
master - mean (766ms) : 708, 823
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8244) - mean (102ms) : 98, 105
master - mean (104ms) : 101, 107
section Bailout
This PR (8244) - mean (103ms) : 101, 106
master - mean (105ms) : 103, 107
section CallTarget+Inlining+NGEN
This PR (8244) - mean (754ms) : 696, 811
master - mean (768ms) : 707, 828
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8244) - mean (100ms) : 97, 104
master - mean (103ms) : 100, 105
section Bailout
This PR (8244) - mean (103ms) : 100, 105
master - mean (103ms) : 101, 105
section CallTarget+Inlining+NGEN
This PR (8244) - mean (676ms) : 648, 704
master - mean (681ms) : 651, 712
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8244) - mean (194ms) : 189, 199
master - mean (195ms) : 191, 199
section Bailout
This PR (8244) - mean (198ms) : 194, 201
master - mean (199ms) : 196, 202
section CallTarget+Inlining+NGEN
This PR (8244) - mean (1,153ms) : 1093, 1212
master - mean (1,155ms) : 1095, 1215
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8244) - mean (278ms) : 271, 286
master - mean (279ms) : 272, 286
section Bailout
This PR (8244) - mean (279ms) : 274, 283
master - mean (279ms) : 275, 284
section CallTarget+Inlining+NGEN
This PR (8244) - mean (944ms) : 909, 979
master - mean (950ms) : 913, 986
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8244) - mean (271ms) : 265, 277
master - mean (274ms) : 268, 279
section Bailout
This PR (8244) - mean (271ms) : 265, 278
master - mean (272ms) : 269, 276
section CallTarget+Inlining+NGEN
This PR (8244) - mean (939ms) : 909, 969
master - mean (934ms) : 903, 965
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8244) - mean (270ms) : 265, 276
master - mean (270ms) : 265, 275
section Bailout
This PR (8244) - mean (271ms) : 265, 277
master - mean (270ms) : 266, 275
section CallTarget+Inlining+NGEN
This PR (8244) - mean (833ms) : 816, 851
master - mean (836ms) : 813, 859
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-03-06 07:53:57 Comparing candidate commit 789a0f4 in PR branch Found 10 performance improvements and 6 performance regressions! Performance is the same for 160 metrics, 16 unstable metrics. scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice netcoreapp3.1
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net6.0
scenario:Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync net472
scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog net472
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan net6.0
scenario:Benchmarks.Trace.SpanBenchmark.StartFinishSpan netcoreapp3.1
scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin net6.0
|
gleocadie
force-pushed
the
gleocadie/add-alpine-support-for-crashtracker-2
branch
10 times, most recently
from
7b5ad83 to
be99586
Compare
gleocadie
force-pushed
the
gleocadie/add-alpine-support-for-crashtracker-2
branch
3 times, most recently
from
ab97ee2 to
6fc748b
Compare
gleocadie
force-pushed
the
gleocadie/add-alpine-support-for-crashtracker-2
branch
from
6fc748b to
789a0f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Implementation details
Test coverage
Other details