Skip to content

Request feature flag config on the first RC poll #11465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
May 27, 2026
+11 −6
Merged

Request feature flag config on the first RC poll #11465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c45d0c5
Request feature flag config on the first RC poll
leoromanovsky May 27, 2026
1a4f70a
Clarify first feature flag RC poll smoke test
leoromanovsky May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,11 +678,12 @@ public void execute() {
maybeStartAppSec(scoClass, sco);
maybeStartCiVisibility(instrumentation, scoClass, sco);
maybeStartLLMObs(instrumentation, scoClass, sco);
// start debugger before remote config to subscribe to it before starting to poll
// Start RC-backed products before remote config so their products and capabilities are
// included in the first poll.
maybeStartDebugger(instrumentation, scoClass, sco);
maybeStartFeatureFlagging(scoClass, sco);
maybeStartRemoteConfig(scoClass, sco);
maybeStartAiGuard();
maybeStartFeatureFlagging(scoClass, sco);

if (telemetryEnabled) {
startTelemetry(instrumentation, scoClass, sco);
Expand Down
12 changes: 8 additions & 4 deletions ...nfeature/src/test/groovy/datadog/smoketest/springboot/OpenFeatureProviderSmokeTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,18 @@ class OpenFeatureProviderSmokeTest extends AbstractServerSmokeTest {
}
}

void 'test remote config'() {
void 'test first remote config poll asks agent for feature flags'() {
when:
final rcRequest = waitForRcClientRequest { req ->
decodeProducts(req).find { it == Product.FFE_FLAGS } != null
final firstRcRequest = waitForRcClientRequest { req ->
return true
}

then:
final capabilities = decodeCapabilities(rcRequest)
firstRcRequest == rcClientMessages.first()
// An already-running Agent gives a newly-started tracer one new-client cache bypass. If
// FFE_FLAGS is missing here and only appears on a later poll, the Agent can miss the fast path.
decodeProducts(firstRcRequest).find { it == Product.FFE_FLAGS } != null
final capabilities = decodeCapabilities(firstRcRequest)
hasCapability(capabilities, Capabilities.CAPABILITY_FFE_FLAG_CONFIGURATION_RULES)
}

Expand Down