Improve JSON component - #12086
Conversation
There was a problem hiding this comment.
The payload dispatcher now serializes trace, span, and parent IDs as JSON strings even though the file format requires numeric fields, and the existing dispatcher test would reject this output. Separately, the new byte-size check reads an unflushed UTF-8 encoder buffer, so OTLP payload limits can be exceeded before the collector notices.
📊 Validated against 2 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit bcd1db5 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcd1db5cab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🎯 Code Coverage (details) 🔗 Commit SHA: 3db42b6 | Docs | Datadog PR Page | Give us feedback! |
|
Bits Code status: ✅ Done Comment @DataDog to request changes |
Size is now exact and do no longer need separate counting
This avoids creating intermediate writer to map collection in existing json/writter
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
bric3
left a comment
There was a problem hiding this comment.
I would rename the PR to be more descriptive to the improvements.
Otherwise looks good to me
Any suggestion? Because I need to keep it short for the changelog while the 3 commits address different topics 😓 |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Build pipeline has failing jobs for 1d5b3fb:
What to do next?
DetailsSince those jobs are not marked as being allowed to fail, the pipeline will most likely fail. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
This PR improves the JSON component by:
Motivation
Simplify the code and avoid duplicate output stream and byte array allocations.
Additional Notes
This PR is a follow up of #12052.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-1620