-
Notifications
You must be signed in to change notification settings - Fork 470
chore(llmobs): add base datasets for experiments #13852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 285 ± 4 ms. The average import time from base is: 290 ± 7 ms. The import time difference between this PR and base is: -5.0 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-07-09 18:03:19 Comparing candidate commit 06c2352 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 547 metrics, 2 unstable metrics. scenario:telemetryaddmetric-1-distribution-metric-1-times
|
Yun-Kim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial thoughts!
8387a40 to
46ddf4d
Compare
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes to .gitlab/services.yml and docker-compose.yml lgtm
This change will depend on fixes in #13911 in order to be merged.
gary-huang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for the first pass
Adds the basic support for creating and pulling dataset objects from the new Datadog LLMObs Experiments product. Testing is done using the new cassette logic added in 1.27.4 to the test agent which enables us to easily record requests made to the Datadog API. Instructions for running the tests are included at the top of the tests file. Dependent on DataDog/dd-apm-test-agent#223 being merged + released. [](https://datadoghq.atlassian.net/browse/MLOB-3260)
Adds the basic support for creating and pulling dataset objects from the new Datadog LLMObs Experiments product.
Testing is done using the new cassette logic added in 1.27.4 to the test agent which enables us to easily record requests made to the Datadog API. Instructions for running the tests are included at the top of the tests file.
Dependent on DataDog/dd-apm-test-agent#223 being merged + released.
Checklist
Reviewer Checklist