-
Notifications
You must be signed in to change notification settings - Fork 469
feat(profiling): profile asyncio.Condition primitives with Python Lock profiler #15550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vlad-scherbich
wants to merge
4
commits into
main
Choose a base branch
from
vlad/lockprof-asyncio-condition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+249
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 3 ms. The average import time from base is: 265 ± 7 ms. The import time difference between this PR and base is: -14.1 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
57f1703 to
f333100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datadoghq.atlassian.net/browse/PROF-12724
Description
Adds profiling support for
asyncio.Conditionto the Python Lock profiler. This extends the lock profiling capability to include condition variables in asynchronous applications.Motivation
asyncio.Conditionis a synchronization primitive that allows tasks to wait for a specific condition. Profiling Condition usage helps identify:Changes
AsyncioConditionCollectorinddtrace/profiling/collector/asyncio.py.asyncio.Conditionalso creates an internalasyncio.Lock, and since we now have a handful of lock types following the same pattern, theis_internallogic was generalized by adding aINTERNAL_MODULE_FILEclass attribute toLockCollector.Testing
TestAsyncioConditionCollectorwithtest_condition_wait_notifytestBaseAsyncioLockCollectorTest