-
Notifications
You must be signed in to change notification settings - Fork 470
chore(tracer): revert prevent some fatal failures on metastruct serialisation #15577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tracer): revert prevent some fatal failures on metastruct serialisation #15577
Conversation
…alisatio…" This reverts commit 2d3267b.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 250 ± 10 ms. The average import time from base is: 260 ± 10 ms. The import time difference between this PR and base is: -8.3 ± 0.6 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate revert-15551-christophe-papazian/mitigate_msgpack_encoding_errors (eb8cc5a) with baseline main (ddecdc2) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same Memory: ✅ 38.360MB (SLO: <41.500MB -7.6%) vs baseline: +4.1% ✅ add_inplace_aspectTime: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.3% Memory: ✅ 38.660MB (SLO: <41.500MB -6.8%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 0.287µs (SLO: <10.000µs 📉 -97.1%) vs baseline: -0.4% Memory: ✅ 38.457MB (SLO: <41.500MB -7.3%) vs baseline: +4.4% ✅ add_noaspectTime: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +0.4% Memory: ✅ 38.472MB (SLO: <41.500MB -7.3%) vs baseline: +4.6% ✅ bytearray_aspectTime: ✅ 1.318µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +1.0% Memory: ✅ 38.540MB (SLO: <41.500MB -7.1%) vs baseline: +4.6% ✅ bytearray_extend_aspectTime: ✅ 1.456µs (SLO: <10.000µs 📉 -85.4%) vs baseline: -2.4% Memory: ✅ 38.660MB (SLO: <41.500MB -6.8%) vs baseline: +5.2% ✅ bytearray_extend_noaspectTime: ✅ 0.619µs (SLO: <10.000µs 📉 -93.8%) vs baseline: -1.7% Memory: ✅ 38.530MB (SLO: <41.500MB -7.2%) vs baseline: +4.3% ✅ bytearray_noaspectTime: ✅ 0.484µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.5% Memory: ✅ 38.476MB (SLO: <41.500MB -7.3%) vs baseline: +4.6% ✅ bytes_aspectTime: ✅ 1.265µs (SLO: <10.000µs 📉 -87.3%) vs baseline: -0.7% Memory: ✅ 38.708MB (SLO: <41.500MB -6.7%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.3% Memory: ✅ 38.519MB (SLO: <41.500MB -7.2%) vs baseline: +4.6% ✅ bytesio_aspectTime: ✅ 1.310µs (SLO: <10.000µs 📉 -86.9%) vs baseline: +1.0% Memory: ✅ 38.647MB (SLO: <41.500MB -6.9%) vs baseline: +5.3% ✅ bytesio_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.2% Memory: ✅ 38.572MB (SLO: <41.500MB -7.1%) vs baseline: +4.5% ✅ capitalize_aspectTime: ✅ 0.735µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -1.8% Memory: ✅ 38.486MB (SLO: <41.500MB -7.3%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 0.440µs (SLO: <10.000µs 📉 -95.6%) vs baseline: ~same Memory: ✅ 38.547MB (SLO: <41.500MB -7.1%) vs baseline: +4.9% ✅ casefold_aspectTime: ✅ 0.738µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.9% Memory: ✅ 38.397MB (SLO: <41.500MB -7.5%) vs baseline: +4.2% ✅ casefold_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.6% Memory: ✅ 38.589MB (SLO: <41.500MB -7.0%) vs baseline: +4.7% ✅ decode_aspectTime: ✅ 0.727µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.7% Memory: ✅ 38.533MB (SLO: <41.500MB -7.2%) vs baseline: +4.9% ✅ decode_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -1.2% Memory: ✅ 38.466MB (SLO: <41.500MB -7.3%) vs baseline: +5.3% ✅ encode_aspectTime: ✅ 0.717µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.1% Memory: ✅ 38.424MB (SLO: <41.500MB -7.4%) vs baseline: +4.3% ✅ encode_noaspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.5% Memory: ✅ 38.446MB (SLO: <41.500MB -7.4%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.397µs (SLO: <10.000µs 📉 -66.0%) vs baseline: -1.0% Memory: ✅ 38.504MB (SLO: <41.500MB -7.2%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 3.614µs (SLO: <10.000µs 📉 -63.9%) vs baseline: +1.2% Memory: ✅ 38.540MB (SLO: <41.500MB -7.1%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 0.833µs (SLO: <10.000µs 📉 -91.7%) vs baseline: +2.0% Memory: ✅ 38.576MB (SLO: <41.500MB -7.0%) vs baseline: +5.1% ✅ format_noaspectTime: ✅ 0.592µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -1.0% Memory: ✅ 38.518MB (SLO: <41.500MB -7.2%) vs baseline: +5.2% ✅ index_aspectTime: ✅ 0.345µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -1.3% Memory: ✅ 38.585MB (SLO: <41.500MB -7.0%) vs baseline: +5.0% ✅ index_noaspectTime: ✅ 0.311µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -0.5% Memory: ✅ 38.549MB (SLO: <41.500MB -7.1%) vs baseline: +4.4% ✅ join_aspectTime: ✅ 1.298µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -0.2% Memory: ✅ 38.618MB (SLO: <41.500MB -6.9%) vs baseline: +4.6% ✅ join_noaspectTime: ✅ 0.532µs (SLO: <10.000µs 📉 -94.7%) vs baseline: ~same Memory: ✅ 38.354MB (SLO: <41.500MB -7.6%) vs baseline: +4.0% ✅ ljust_aspectTime: ✅ 2.561µs (SLO: <20.000µs 📉 -87.2%) vs baseline: +2.9% Memory: ✅ 38.342MB (SLO: <41.500MB -7.6%) vs baseline: +4.2% ✅ ljust_noaspectTime: ✅ 0.409µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.9% Memory: ✅ 38.423MB (SLO: <41.500MB -7.4%) vs baseline: +4.5% ✅ lower_aspectTime: ✅ 2.211µs (SLO: <10.000µs 📉 -77.9%) vs baseline: -0.8% Memory: ✅ 38.440MB (SLO: <41.500MB -7.4%) vs baseline: +4.7% ✅ lower_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 38.478MB (SLO: <41.500MB -7.3%) vs baseline: +4.4% ✅ lstrip_aspectTime: ✅ 2.187µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.3% Memory: ✅ 38.614MB (SLO: <41.500MB -7.0%) vs baseline: +4.8% ✅ lstrip_noaspectTime: ✅ 0.386µs (SLO: <10.000µs 📉 -96.1%) vs baseline: ~same Memory: ✅ 38.437MB (SLO: <41.500MB -7.4%) vs baseline: +4.4% ✅ modulo_aspectTime: ✅ 0.972µs (SLO: <10.000µs 📉 -90.3%) vs baseline: +0.4% Memory: ✅ 38.536MB (SLO: <41.500MB -7.1%) vs baseline: +5.2% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.490µs (SLO: <10.000µs 📉 -85.1%) vs baseline: +0.8% Memory: ✅ 38.528MB (SLO: <41.500MB -7.2%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.953µs (SLO: <10.000µs 📉 -90.5%) vs baseline: -0.7% Memory: ✅ 38.474MB (SLO: <41.500MB -7.3%) vs baseline: +4.7% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.173µs (SLO: <10.000µs 📉 -88.3%) vs baseline: +0.4% Memory: ✅ 38.626MB (SLO: <41.500MB -6.9%) vs baseline: +4.8% ✅ modulo_noaspectTime: ✅ 0.671µs (SLO: <10.000µs 📉 -93.3%) vs baseline: -0.2% Memory: ✅ 38.467MB (SLO: <41.500MB -7.3%) vs baseline: +4.3% ✅ replace_aspectTime: ✅ 5.477µs (SLO: <10.000µs 📉 -45.2%) vs baseline: 📈 +11.8% Memory: ✅ 38.354MB (SLO: <41.500MB -7.6%) vs baseline: +4.3% ✅ replace_noaspectTime: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -1.7% Memory: ✅ 38.488MB (SLO: <41.500MB -7.3%) vs baseline: +5.2% ✅ repr_aspectTime: ✅ 0.956µs (SLO: <10.000µs 📉 -90.4%) vs baseline: -0.2% Memory: ✅ 38.542MB (SLO: <41.500MB -7.1%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.455µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.4% Memory: ✅ 38.588MB (SLO: <41.500MB -7.0%) vs baseline: +4.7% ✅ rstrip_aspectTime: ✅ 1.851µs (SLO: <20.000µs 📉 -90.7%) vs baseline: +0.7% Memory: ✅ 38.563MB (SLO: <41.500MB -7.1%) vs baseline: +5.0% ✅ rstrip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.3% Memory: ✅ 38.570MB (SLO: <41.500MB -7.1%) vs baseline: +4.7% ✅ slice_aspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +1.1% Memory: ✅ 38.513MB (SLO: <41.500MB -7.2%) vs baseline: +4.7% ✅ slice_noaspectTime: ✅ 0.452µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.5% Memory: ✅ 38.578MB (SLO: <41.500MB -7.0%) vs baseline: +5.1% ✅ stringio_aspectTime: ✅ 1.686µs (SLO: <10.000µs 📉 -83.1%) vs baseline: +0.4% Memory: ✅ 38.570MB (SLO: <41.500MB -7.1%) vs baseline: +4.6% ✅ stringio_noaspectTime: ✅ 0.917µs (SLO: <10.000µs 📉 -90.8%) vs baseline: -0.3% Memory: ✅ 38.472MB (SLO: <41.500MB -7.3%) vs baseline: +4.6% ✅ strip_aspectTime: ✅ 2.439µs (SLO: <20.000µs 📉 -87.8%) vs baseline: 📈 +10.6% Memory: ✅ 38.594MB (SLO: <41.500MB -7.0%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 0.390µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.9% Memory: ✅ 38.503MB (SLO: <41.500MB -7.2%) vs baseline: +4.4% ✅ swapcase_aspectTime: ✅ 2.412µs (SLO: <10.000µs 📉 -75.9%) vs baseline: +0.5% Memory: ✅ 38.546MB (SLO: <41.500MB -7.1%) vs baseline: +4.5% ✅ swapcase_noaspectTime: ✅ 0.545µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +1.1% Memory: ✅ 38.724MB (SLO: <41.500MB -6.7%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 2.336µs (SLO: <10.000µs 📉 -76.6%) vs baseline: ~same Memory: ✅ 38.308MB (SLO: <41.500MB -7.7%) vs baseline: +4.1% ✅ title_noaspectTime: ✅ 0.507µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +1.0% Memory: ✅ 38.551MB (SLO: <41.500MB -7.1%) vs baseline: +5.2% ✅ translate_aspectTime: ✅ 3.265µs (SLO: <10.000µs 📉 -67.3%) vs baseline: +2.1% Memory: ✅ 38.553MB (SLO: <41.500MB -7.1%) vs baseline: +4.6% ✅ translate_noaspectTime: ✅ 1.038µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.1% Memory: ✅ 38.591MB (SLO: <41.500MB -7.0%) vs baseline: +5.1% ✅ upper_aspectTime: ✅ 2.286µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +2.4% Memory: ✅ 38.430MB (SLO: <41.500MB -7.4%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 38.441MB (SLO: <41.500MB -7.4%) vs baseline: +4.5% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.078µs (SLO: <10.000µs 📉 -49.2%) vs baseline: 📈 +20.3% Memory: ✅ 38.574MB (SLO: <41.000MB -5.9%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.086µs (SLO: <10.000µs 📉 -89.1%) vs baseline: ~same Memory: ✅ 38.437MB (SLO: <41.000MB -6.3%) vs baseline: +4.2% ✅ ospathjoin_aspectTime: ✅ 5.967µs (SLO: <10.000µs 📉 -40.3%) vs baseline: -1.7% Memory: ✅ 38.496MB (SLO: <41.000MB -6.1%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 2.297µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.5% Memory: ✅ 38.476MB (SLO: <41.000MB -6.2%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.445µs (SLO: <10.000µs 📉 -65.5%) vs baseline: -0.3% Memory: ✅ 38.476MB (SLO: <41.000MB -6.2%) vs baseline: +4.5% ✅ ospathnormcase_noaspectTime: ✅ 0.576µs (SLO: <10.000µs 📉 -94.2%) vs baseline: +1.1% Memory: ✅ 38.476MB (SLO: <41.000MB -6.2%) vs baseline: +4.5% ✅ ospathsplit_aspectTime: ✅ 4.796µs (SLO: <10.000µs 📉 -52.0%) vs baseline: -1.5% Memory: ✅ 38.516MB (SLO: <41.000MB -6.1%) vs baseline: +4.6% ✅ ospathsplit_noaspectTime: ✅ 1.588µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.5% Memory: ✅ 38.496MB (SLO: <41.000MB -6.1%) vs baseline: +4.6% ✅ ospathsplitdrive_aspectTime: ✅ 3.658µs (SLO: <10.000µs 📉 -63.4%) vs baseline: -0.9% Memory: ✅ 38.516MB (SLO: <41.000MB -6.1%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.702µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.6% Memory: ✅ 38.555MB (SLO: <41.000MB -6.0%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.548µs (SLO: <10.000µs 📉 -54.5%) vs baseline: +0.2% Memory: ✅ 38.653MB (SLO: <41.000MB -5.7%) vs baseline: +5.1% ✅ ospathsplitext_noaspectTime: ✅ 1.379µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.5% Memory: ✅ 38.555MB (SLO: <41.000MB -6.0%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.387µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +17.5% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +4.7% ✅ 1-count-metrics-100-timesTime: ✅ 202.417µs (SLO: <220.000µs -8.0%) vs baseline: +1.4% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.1% ✅ 1-distribution-metric-1-timesTime: ✅ 3.274µs (SLO: <20.000µs 📉 -83.6%) vs baseline: +1.5% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 218.585µs (SLO: <230.000µs -5.0%) vs baseline: +2.3% Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.165µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -0.1% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.3% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.859µs (SLO: <150.000µs -8.8%) vs baseline: -0.3% Memory: ✅ 34.977MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.071µs (SLO: <20.000µs 📉 -84.6%) vs baseline: +2.2% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 215.220µs (SLO: <250.000µs 📉 -13.9%) vs baseline: +1.4% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.3% ✅ 100-count-metrics-100-timesTime: ✅ 20.280ms (SLO: <22.000ms -7.8%) vs baseline: +1.2% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.255ms (SLO: <2.550ms 📉 -11.6%) vs baseline: +0.2% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.2% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.408ms (SLO: <1.550ms -9.1%) vs baseline: +0.7% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.2% ✅ 100-rate-metrics-100-timesTime: ✅ 2.215ms (SLO: <2.550ms 📉 -13.1%) vs baseline: +1.6% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.1% ✅ flush-1-metricTime: ✅ 4.622µs (SLO: <20.000µs 📉 -76.9%) vs baseline: +1.7% Memory: ✅ 35.055MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 173.662µs (SLO: <250.000µs 📉 -30.5%) vs baseline: +0.4% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.178ms (SLO: <2.500ms 📉 -12.9%) vs baseline: +0.1% Memory: ✅ 35.940MB (SLO: <36.500MB 🟡 -1.5%) vs baseline: +4.9% 🟡 Near SLO Breach (14 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
…gpack_encoding_errors
Reverts #15551
The vendor tests are dependent on these changes, but they did not run as part of the original PR.