-
Notifications
You must be signed in to change notification settings - Fork 470
chore(tracer): remove hooks usage and replace with coreapi #15605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 246 ± 3 ms. The average import time from base is: 249 ± 3 ms. The import time difference between this PR and base is: -3.4 ± 0.1 ms. Import time breakdownThe following import paths have disappeared:
|
Performance SLOsComparing candidate remove_ddtrace._hooks.Hooks (a55cee2) with baseline main (f13aae0) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -0.8% Memory: ✅ 38.528MB (SLO: <41.500MB -7.2%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.7% Memory: ✅ 38.242MB (SLO: <41.500MB -7.9%) vs baseline: +3.4% ✅ add_inplace_noaspectTime: ✅ 0.287µs (SLO: <10.000µs 📉 -97.1%) vs baseline: +1.1% Memory: ✅ 38.496MB (SLO: <41.500MB -7.2%) vs baseline: +4.4% ✅ add_noaspectTime: ✅ 0.355µs (SLO: <10.000µs 📉 -96.5%) vs baseline: -0.7% Memory: ✅ 38.548MB (SLO: <41.500MB -7.1%) vs baseline: +4.4% ✅ bytearray_aspectTime: ✅ 1.262µs (SLO: <10.000µs 📉 -87.4%) vs baseline: -3.7% Memory: ✅ 38.334MB (SLO: <41.500MB -7.6%) vs baseline: +4.0% ✅ bytearray_extend_aspectTime: ✅ 1.547µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +5.1% Memory: ✅ 38.404MB (SLO: <41.500MB -7.5%) vs baseline: +4.3% ✅ bytearray_extend_noaspectTime: ✅ 0.613µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.9% Memory: ✅ 38.556MB (SLO: <41.500MB -7.1%) vs baseline: +5.0% ✅ bytearray_noaspectTime: ✅ 0.481µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -1.5% Memory: ✅ 38.429MB (SLO: <41.500MB -7.4%) vs baseline: +4.5% ✅ bytes_aspectTime: ✅ 1.264µs (SLO: <10.000µs 📉 -87.4%) vs baseline: -0.1% Memory: ✅ 38.569MB (SLO: <41.500MB -7.1%) vs baseline: +5.1% ✅ bytes_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.7% Memory: ✅ 38.398MB (SLO: <41.500MB -7.5%) vs baseline: +4.2% ✅ bytesio_aspectTime: ✅ 1.329µs (SLO: <10.000µs 📉 -86.7%) vs baseline: +1.8% Memory: ✅ 38.332MB (SLO: <41.500MB -7.6%) vs baseline: +4.3% ✅ bytesio_noaspectTime: ✅ 0.503µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6% Memory: ✅ 38.278MB (SLO: <41.500MB -7.8%) vs baseline: +3.5% ✅ capitalize_aspectTime: ✅ 0.740µs (SLO: <10.000µs 📉 -92.6%) vs baseline: ~same Memory: ✅ 38.578MB (SLO: <41.500MB -7.0%) vs baseline: +4.6% ✅ capitalize_noaspectTime: ✅ 0.434µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.1% Memory: ✅ 38.513MB (SLO: <41.500MB -7.2%) vs baseline: +4.7% ✅ casefold_aspectTime: ✅ 0.746µs (SLO: <10.000µs 📉 -92.5%) vs baseline: +0.8% Memory: ✅ 38.502MB (SLO: <41.500MB -7.2%) vs baseline: +4.8% ✅ casefold_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.8% Memory: ✅ 38.547MB (SLO: <41.500MB -7.1%) vs baseline: +4.9% ✅ decode_aspectTime: ✅ 0.730µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.1% Memory: ✅ 38.708MB (SLO: <41.500MB -6.7%) vs baseline: +5.1% ✅ decode_noaspectTime: ✅ 0.421µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -1.2% Memory: ✅ 38.434MB (SLO: <41.500MB -7.4%) vs baseline: +4.0% ✅ encode_aspectTime: ✅ 0.715µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.5% Memory: ✅ 38.611MB (SLO: <41.500MB -7.0%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.7% Memory: ✅ 38.412MB (SLO: <41.500MB -7.4%) vs baseline: +4.4% ✅ format_aspectTime: ✅ 3.447µs (SLO: <10.000µs 📉 -65.5%) vs baseline: +1.4% Memory: ✅ 38.605MB (SLO: <41.500MB -7.0%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 3.674µs (SLO: <10.000µs 📉 -63.3%) vs baseline: +1.3% Memory: ✅ 38.368MB (SLO: <41.500MB -7.5%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 0.827µs (SLO: <10.000µs 📉 -91.7%) vs baseline: +1.2% Memory: ✅ 38.572MB (SLO: <41.500MB -7.1%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 0.600µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +1.2% Memory: ✅ 38.426MB (SLO: <41.500MB -7.4%) vs baseline: +4.7% ✅ index_aspectTime: ✅ 0.345µs (SLO: <10.000µs 📉 -96.6%) vs baseline: -0.8% Memory: ✅ 38.511MB (SLO: <41.500MB -7.2%) vs baseline: +4.1% ✅ index_noaspectTime: ✅ 0.315µs (SLO: <10.000µs 📉 -96.9%) vs baseline: -1.2% Memory: ✅ 38.526MB (SLO: <41.500MB -7.2%) vs baseline: +4.8% ✅ join_aspectTime: ✅ 1.280µs (SLO: <10.000µs 📉 -87.2%) vs baseline: -3.2% Memory: ✅ 38.680MB (SLO: <41.500MB -6.8%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.532µs (SLO: <10.000µs 📉 -94.7%) vs baseline: ~same Memory: ✅ 38.432MB (SLO: <41.500MB -7.4%) vs baseline: +4.3% ✅ ljust_aspectTime: ✅ 2.586µs (SLO: <20.000µs 📉 -87.1%) vs baseline: +0.7% Memory: ✅ 38.401MB (SLO: <41.500MB -7.5%) vs baseline: +4.3% ✅ ljust_noaspectTime: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +1.0% Memory: ✅ 38.285MB (SLO: <41.500MB -7.7%) vs baseline: +3.7% ✅ lower_aspectTime: ✅ 2.243µs (SLO: <10.000µs 📉 -77.6%) vs baseline: +0.6% Memory: ✅ 38.514MB (SLO: <41.500MB -7.2%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 0.371µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.2% Memory: ✅ 38.330MB (SLO: <41.500MB -7.6%) vs baseline: +3.9% ✅ lstrip_aspectTime: ✅ 2.206µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +2.0% Memory: ✅ 38.502MB (SLO: <41.500MB -7.2%) vs baseline: +4.5% ✅ lstrip_noaspectTime: ✅ 0.389µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +1.6% Memory: ✅ 38.590MB (SLO: <41.500MB -7.0%) vs baseline: +4.3% ✅ modulo_aspectTime: ✅ 0.967µs (SLO: <10.000µs 📉 -90.3%) vs baseline: ~same Memory: ✅ 38.511MB (SLO: <41.500MB -7.2%) vs baseline: +4.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.500µs (SLO: <10.000µs 📉 -85.0%) vs baseline: +1.2% Memory: ✅ 38.372MB (SLO: <41.500MB -7.5%) vs baseline: +4.6% ✅ modulo_aspect_for_bytesTime: ✅ 0.955µs (SLO: <10.000µs 📉 -90.4%) vs baseline: +0.3% Memory: ✅ 38.484MB (SLO: <41.500MB -7.3%) vs baseline: +4.7% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.170µs (SLO: <10.000µs 📉 -88.3%) vs baseline: ~same Memory: ✅ 38.605MB (SLO: <41.500MB -7.0%) vs baseline: +5.0% ✅ modulo_noaspectTime: ✅ 0.667µs (SLO: <10.000µs 📉 -93.3%) vs baseline: +0.2% Memory: ✅ 38.392MB (SLO: <41.500MB -7.5%) vs baseline: +4.2% ✅ replace_aspectTime: ✅ 5.029µs (SLO: <10.000µs 📉 -49.7%) vs baseline: +2.2% Memory: ✅ 38.438MB (SLO: <41.500MB -7.4%) vs baseline: +4.7% ✅ replace_noaspectTime: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.6% Memory: ✅ 38.586MB (SLO: <41.500MB -7.0%) vs baseline: +5.0% ✅ repr_aspectTime: ✅ 0.946µs (SLO: <10.000µs 📉 -90.5%) vs baseline: ~same Memory: ✅ 38.701MB (SLO: <41.500MB -6.7%) vs baseline: +5.4% ✅ repr_noaspectTime: ✅ 0.456µs (SLO: <10.000µs 📉 -95.4%) vs baseline: ~same Memory: ✅ 38.651MB (SLO: <41.500MB -6.9%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 1.859µs (SLO: <20.000µs 📉 -90.7%) vs baseline: +1.7% Memory: ✅ 38.643MB (SLO: <41.500MB -6.9%) vs baseline: +5.2% ✅ rstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.1% Memory: ✅ 38.594MB (SLO: <41.500MB -7.0%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.486µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.8% Memory: ✅ 38.446MB (SLO: <41.500MB -7.4%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 0.452µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.1% Memory: ✅ 38.412MB (SLO: <41.500MB -7.4%) vs baseline: +4.3% ✅ stringio_aspectTime: ✅ 1.676µs (SLO: <10.000µs 📉 -83.2%) vs baseline: ~same Memory: ✅ 38.492MB (SLO: <41.500MB -7.2%) vs baseline: +4.7% ✅ stringio_noaspectTime: ✅ 0.919µs (SLO: <10.000µs 📉 -90.8%) vs baseline: -0.2% Memory: ✅ 38.279MB (SLO: <41.500MB -7.8%) vs baseline: +4.3% ✅ strip_aspectTime: ✅ 2.416µs (SLO: <20.000µs 📉 -87.9%) vs baseline: 📈 +12.1% Memory: ✅ 38.426MB (SLO: <41.500MB -7.4%) vs baseline: +4.5% ✅ strip_noaspectTime: ✅ 0.387µs (SLO: <10.000µs 📉 -96.1%) vs baseline: -0.4% Memory: ✅ 38.406MB (SLO: <41.500MB -7.5%) vs baseline: +4.3% ✅ swapcase_aspectTime: ✅ 2.436µs (SLO: <10.000µs 📉 -75.6%) vs baseline: +0.1% Memory: ✅ 38.431MB (SLO: <41.500MB -7.4%) vs baseline: +4.0% ✅ swapcase_noaspectTime: ✅ 0.544µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +1.5% Memory: ✅ 38.538MB (SLO: <41.500MB -7.1%) vs baseline: +4.4% ✅ title_aspectTime: ✅ 2.363µs (SLO: <10.000µs 📉 -76.4%) vs baseline: +0.5% Memory: ✅ 38.589MB (SLO: <41.500MB -7.0%) vs baseline: +4.9% ✅ title_noaspectTime: ✅ 0.504µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.1% Memory: ✅ 38.499MB (SLO: <41.500MB -7.2%) vs baseline: +4.4% ✅ translate_aspectTime: ✅ 3.245µs (SLO: <10.000µs 📉 -67.5%) vs baseline: ~same Memory: ✅ 38.401MB (SLO: <41.500MB -7.5%) vs baseline: +4.4% ✅ translate_noaspectTime: ✅ 1.044µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.3% Memory: ✅ 38.516MB (SLO: <41.500MB -7.2%) vs baseline: +5.0% ✅ upper_aspectTime: ✅ 2.413µs (SLO: <10.000µs 📉 -75.9%) vs baseline: +5.9% Memory: ✅ 38.641MB (SLO: <41.500MB -6.9%) vs baseline: +5.3% ✅ upper_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.3% Memory: ✅ 38.421MB (SLO: <41.500MB -7.4%) vs baseline: +4.7% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.087µs (SLO: <10.000µs 📉 -49.1%) vs baseline: 📈 +21.5% Memory: ✅ 38.673MB (SLO: <41.000MB -5.7%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 1.091µs (SLO: <10.000µs 📉 -89.1%) vs baseline: -0.1% Memory: ✅ 38.594MB (SLO: <41.000MB -5.9%) vs baseline: +4.7% ✅ ospathjoin_aspectTime: ✅ 6.049µs (SLO: <10.000µs 📉 -39.5%) vs baseline: +0.7% Memory: ✅ 38.633MB (SLO: <41.000MB -5.8%) vs baseline: +5.3% ✅ ospathjoin_noaspectTime: ✅ 2.298µs (SLO: <10.000µs 📉 -77.0%) vs baseline: ~same Memory: ✅ 38.614MB (SLO: <41.000MB -5.8%) vs baseline: +4.9% ✅ ospathnormcase_aspectTime: ✅ 3.533µs (SLO: <10.000µs 📉 -64.7%) vs baseline: +1.4% Memory: ✅ 38.594MB (SLO: <41.000MB -5.9%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 0.570µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +0.3% Memory: ✅ 38.653MB (SLO: <41.000MB -5.7%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.837µs (SLO: <10.000µs 📉 -51.6%) vs baseline: ~same Memory: ✅ 38.633MB (SLO: <41.000MB -5.8%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.587µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.5% Memory: ✅ 38.594MB (SLO: <41.000MB -5.9%) vs baseline: +4.9% ✅ ospathsplitdrive_aspectTime: ✅ 3.745µs (SLO: <10.000µs 📉 -62.5%) vs baseline: +0.7% Memory: ✅ 38.633MB (SLO: <41.000MB -5.8%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.703µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.4% Memory: ✅ 38.614MB (SLO: <41.000MB -5.8%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 4.588µs (SLO: <10.000µs 📉 -54.1%) vs baseline: -0.2% Memory: ✅ 38.614MB (SLO: <41.000MB -5.8%) vs baseline: +4.9% ✅ ospathsplitext_noaspectTime: ✅ 1.384µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.2% Memory: ✅ 38.594MB (SLO: <41.000MB -5.9%) vs baseline: +4.8% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.521µs (SLO: <20.000µs 📉 -82.4%) vs baseline: 📈 +15.4% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 206.243µs (SLO: <220.000µs -6.3%) vs baseline: +0.3% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.371µs (SLO: <20.000µs 📉 -83.1%) vs baseline: -0.6% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.584µs (SLO: <230.000µs -5.8%) vs baseline: -0.7% Memory: ✅ 34.741MB (SLO: <35.500MB -2.1%) vs baseline: +4.4% ✅ 1-gauge-metric-1-timesTime: ✅ 2.198µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -2.3% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.467µs (SLO: <150.000µs -9.0%) vs baseline: -0.4% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.207µs (SLO: <20.000µs 📉 -84.0%) vs baseline: +0.6% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ 1-rate-metrics-100-timesTime: ✅ 219.550µs (SLO: <250.000µs 📉 -12.2%) vs baseline: -0.2% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 21.034ms (SLO: <22.000ms -4.4%) vs baseline: +0.5% Memory: ✅ 34.937MB (SLO: <35.500MB 🟡 -1.6%) vs baseline: +5.2% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.306ms (SLO: <2.550ms -9.6%) vs baseline: ~same Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.412ms (SLO: <1.550ms -8.9%) vs baseline: +0.6% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.292ms (SLO: <2.550ms 📉 -10.1%) vs baseline: +2.1% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.632µs (SLO: <20.000µs 📉 -76.8%) vs baseline: -1.2% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.6% ✅ flush-100-metricsTime: ✅ 173.210µs (SLO: <250.000µs 📉 -30.7%) vs baseline: -0.9% Memory: ✅ 35.095MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.174ms (SLO: <2.500ms 📉 -13.0%) vs baseline: -0.2% Memory: ✅ 35.999MB (SLO: <36.500MB 🟡 -1.4%) vs baseline: +4.9% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Removes the usage of Hooks and replaces with core api dispatch.
Removed Hooks Class
Updated Integration Configuration
Updated Falcon Integration
Updated Tests
Ensured Test Isolation
Testing
use existing tests to see if anything breaks