Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@stylistic/eslint-plugin": "^5.9.0",
"eslint": "^10.0.2",
"eslint-plugin-import-x": "^4.12.2",
"eslint-plugin-n": "^17.24.0",
"eslint-plugin-n": "^18.1.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Handle the ESM-only plugin export before bumping

With this dependency line, yarn lint loads eslint.config.js, which still does const eslintPluginN = require('eslint-plugin-n') and then reads eslintPluginN.configs. In v18 the plugin entrypoint is ESM and default-exports the plugin object, so on modern Node require() returns a namespace object whose configs are under .default (and older Node versions throw ERR_REQUIRE_ESM); the Build workflow's lint job will fail while evaluating the config before linting anything unless the config is converted/updated or this bump is held back.

Useful? React with 👍 / 👎.

"eslint-plugin-unicorn": "^63.0.0",
"globals": "^17.4.0"
}
Expand Down
18 changes: 5 additions & 13 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -431,10 +431,10 @@ eslint-plugin-import-x@^4.12.2:
stable-hash-x "^0.2.0"
unrs-resolver "^1.9.2"

eslint-plugin-n@^17.24.0:
version "17.24.0"
resolved "https://registry.yarnpkg.com/eslint-plugin-n/-/eslint-plugin-n-17.24.0.tgz#b66fa05f7a6c1ba16768f0921b8974147dddd060"
integrity sha512-/gC7/KAYmfNnPNOb3eu8vw+TdVnV0zhdQwexsw6FLXbhzroVj20vRn2qL8lDWDGnAQ2J8DhdfvXxX9EoxvERvw==
eslint-plugin-n@^18.1.0:
version "18.1.0"
resolved "https://registry.yarnpkg.com/eslint-plugin-n/-/eslint-plugin-n-18.1.0.tgz#c1eadf2bc59704bf0078eca8d59743a7386b1081"
integrity sha512-hkUm9EtnFV2h2fE16jNVUfCVUqvPzI7fGLsFdun5lFt/pbmf2kCgDx6ymi9rx+NCUSggBmurJCZOfG20JBs/kg==
dependencies:
"@eslint-community/eslint-utils" "^4.5.0"
enhanced-resolve "^5.17.1"
Expand All @@ -444,7 +444,6 @@ eslint-plugin-n@^17.24.0:
globrex "^0.1.2"
ignore "^5.3.2"
semver "^7.6.3"
ts-declaration-location "^1.0.6"

eslint-plugin-unicorn@^63.0.0:
version "63.0.0"
Expand Down Expand Up @@ -807,7 +806,7 @@ picocolors@^1.1.1:
resolved "https://registry.yarnpkg.com/picocolors/-/picocolors-1.1.1.tgz#3d321af3eab939b083c8f929a1d12cda81c26b6b"
integrity sha512-xceH2snhtb5M9liqDsmEw56le376mTZkEX/jEb/RxNFyegNul7eNslCXP9FDj/Lcu0X8KEyMceP2ntpaHrDEVA==

picomatch@^4.0.2, picomatch@^4.0.3:
picomatch@^4.0.3:
version "4.0.3"
resolved "https://registry.yarnpkg.com/picomatch/-/picomatch-4.0.3.tgz#796c76136d1eead715db1e7bad785dedd695a042"
integrity sha512-5gTmgEY/sqK6gFXLIsQNH19lWb4ebPDLA4SdLP7dsWkIXHWlG66oPuVvXSGFPppYZz8ZDZq0dYYrbHfBCVUb1Q==
Expand Down Expand Up @@ -876,13 +875,6 @@ tapable@^2.3.0:
resolved "https://registry.yarnpkg.com/tapable/-/tapable-2.3.0.tgz#7e3ea6d5ca31ba8e078b560f0d83ce9a14aa8be6"
integrity sha512-g9ljZiwki/LfxmQADO3dEY1CbpmXT5Hm2fJ+QaGKwSXUylMybePR7/67YW7jOrrvjEgL1Fmz5kzyAjWVWLlucg==

ts-declaration-location@^1.0.6:
version "1.0.7"
resolved "https://registry.yarnpkg.com/ts-declaration-location/-/ts-declaration-location-1.0.7.tgz#d4068fe9975828b3b453b3ab112b4711d8267688"
integrity sha512-EDyGAwH1gO0Ausm9gV6T2nUvBgXT5kGoCMJPllOaooZ+4VvJiKBdZE7wK18N1deEowhcUptS+5GXZK8U/fvpwA==
dependencies:
picomatch "^4.0.2"

tslib@^2.4.0:
version "2.8.1"
resolved "https://registry.yarnpkg.com/tslib/-/tslib-2.8.1.tgz#612efe4ed235d567e8aba5f2a5fab70280ade83f"
Expand Down
Loading