Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 30 additions & 14 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion crates/crashtracker/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ path = "src/bin/receiver.rs"
[dependencies]
anyhow = "1"
libdd-crashtracker = { git = "https://github.com/DataDog/libdatadog.git", tag = "v35.0.0" }
napi = { version = "2", features = ["serde-json"] }
napi = { version = "3", features = ["serde-json"] }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Enable compat-mode for crashtracker's v2 APIs

When building the crashtracker crate, this v3 dependency is resolved without compat-mode, but crates/crashtracker/src/unhandled_exception.rs still imports and uses napi::{JsFunction, JsObject}. In napi v3 those legacy JsValue types are only exported under compat-mode, so the crate will fail to compile instead of producing crashtracker.node; please add that feature here or migrate these calls to the v3 Object/Function APIs.

Useful? React with 👍 / 👎.

napi-derive = { version = "2", default-features = false }
rustls = { version = "*", default-features = false, features = ["aws-lc-rs"] }
serde_json = "1"
2 changes: 1 addition & 1 deletion crates/process_discovery/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ crate-type = ["cdylib", "rlib"]
anyhow = "1"
libdd-library-config = { git = "https://github.com/DataDog/libdatadog.git", tag = "v35.0.0", features = ["otel-thread-ctx"] }

napi = { version = "2" }
napi = { version = "3" }
napi-derive = { version = "2", default-features = false }
Loading