fix(incidents): enable v2.list_incident_attachments unstable op#513
Merged
platinummonkey merged 1 commit intoMay 18, 2026
Merged
Conversation
`pup incidents attachments list` was failing with `UnstableOperationDisabledError` because the underlying DD API client flag was not set. Add `v2.list_incident_attachments` to `UNSTABLE_OPS` in `src/client.rs` and bump the count-assertion test. Also add tests for the attachments commands (happy + error paths for both `attachments_list` and `attachments_delete`) to lock in behavior.
platinummonkey
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables the
v2.list_incident_attachmentsunstable operation in the DD API client sopup incidents attachments listactually works instead of failing withUnstableOperationDisabledError.Motivation
The command was unusable:
Additional Notes
UNSTABLE_OPSinsrc/client.rsand bumps the count-assertion test (166 → 167).attachments_listandattachments_delete) — these paths previously had no coverage.Checklist