[SECRES-2420] Support custom verifiers and loggers #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikretz
changed the title
sobregosodd
requested changes
Oct 24, 2024
sobregosodd
reviewed
Oct 28, 2024
sobregosodd
approved these changes
Oct 28, 2024
Contributor
sobregosodd
left a comment
sobregosodd
left a comment
There was a problem hiding this comment.
Sharing some non blocking comments, otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for automatically discovering installation target verifiers and loggers at runtime. Users can now use custom verifiers and loggers with the firewall without having to modify its source code.