test(golang): enable passing ot.th/ot.rv tracestate sampling scenarios [golang@ben.db/feat-otel-th-rv-propagation] - #7389
Open
genesor wants to merge 1 commit into
Conversation
Contributor
|
|
|
genesor
changed the title
genesor
force-pushed
the
ben.db/enable-otel-th-rv-golang-manifest
branch
from
July 29, 2026 15:28
21f109c to
d8eebf8
Compare
genesor
marked this pull request as ready for review
July 29, 2026 15:51
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8eebf8a54
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Stacked on #7372 (the ot.th/ot.rv conformance scaffolding). Enables the Go entries that pass against dd-trace-go's wire implementation (DataDog/dd-trace-go#5060), verified locally against a
golang@2.11.0-devbuild across every scenario (DEFAULT + all five sample-rate scenarios).What does this PR do?
Flips all
tests/test_otel_tracestate_sampling.pyGo entries frommissing_featuretov2.11.0-devinmanifests/golang.yml:Test_EmitOtOnProbabilityDecision_Rate0_01/0_1/0_2/0_5/0_99Test_ForwardInboundOtUnchangedTest_ForceKeepClearsThTest_MalformedOtHandlingTest_PreserveDdAndOtherVendorsTest_SampledWithoutOtNotFabricatedTest_ForceKeepClearsTh's two inherited-rvcases required forcing the AppSec keep to override an inherited/locked upstream drop (fixed in dd-trace-go#5060); all three methods now pass.Base
Targets
ben.db/feat-otel-tracestate-sampling-scaffolding(stacked). Retarget tomainonce #7372 merges.