Skip to content

Adding review rules for codex about adding decorators #7397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nccatoni wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Adding review rules for codex about adding decorators #7397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .cursor/rules/pr-review.mdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,11 @@ When adding a new weblog, verify the name is unique across all languages. Search

- `bug` and `flaky` markers must include a JIRA ticket (e.g., `bug (JIRA-123)`)
- Values with special YAML characters (`>`, `<`, `:`, `#`) must be quoted
- Entries should be sorted alphabetically within each manifest file
- Entries should be sorted alphabetically within each manifest file

## 11. New decorators

PRs should not typically create new decorators. If a PR centered around creating, editing, activating or deactivating tests creates new decorators, it is most likely an error and you should comment with the correct approach.
One exception to that would be creating a new scenario.

- Ref: [skip-tests.md](mdc:docs/edit/skip-tests.md)
Loading