Skip to content

Fix nodejs startup-logs version gate to v6.0.0 #7401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bm1549 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix nodejs startup-logs version gate to v6.0.0 #7401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ refs:
- &ref_5_109_0 '>=5.109.0'
- &ref_5_110_0 '>=5.110.0'
- &ref_5_111_0 '>=5.111.0'
- &ref_6_0_0 '>=6.0.0-pre'
- &ref_6_0_0 '>=6.0.0'

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the main-branch prerelease enabled

When CI tests dd-trace-js main, the library still identifies itself as 6.0.0-pre; because prereleases have lower precedence than their corresponding release, 6.0.0-pre does not satisfy this new >=6.0.0 range. Consequently, test_startup_logs_default is silently disabled for every main-branch build despite the feature being present there, eliminating pre-release regression coverage until a release artifact is tested. Keep a range that includes the main placeholder (as the previous bound did), rather than using the manifest gate to express the historical release boundary.

Useful? React with 👍 / 👎.

@bm1549 bm1549 Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IlyasShabi what do you think about this? Seems the opposite of our discussion

- &ref_6_5_0 '>=6.5.0 || ^5.116.0'
manifest:
tests/ai_guard/test_ai_guard_sdk.py::Test_AIGuardEvent_Tag:
Expand Down
Loading