test(tracestats): add cardinality overflow sentinel test - #7409
Merged
Conversation
Verifies eligible span kinds (server/client/producer/consumer) are computed into stats with their SpanKind while ineligible kinds are excluded. Passes for go/java/dotnet/python; marked missing_feature for nodejs (no SpanKind field) and the no-CSS SDKs.
…ets, gate TS015 for .NET <3.43.0 Addresses PR review: exercise a non-top-level server-kind span, aggregate stats across all /v0.6/stats requests and time buckets, and mark TS015 missing_feature for dd-trace-dotnet <3.43.0 like the sibling CSS tests.
Assert CSS v1.2.0 Cardinality Limits collapse excess stats cardinality into a tracer_blocked_value overflow bucket while preserving service-level totals. dotnet passes; dd-trace-go gated to activate from 2.11.0-dev (#5032); other CSS SDKs marked missing_feature until they honor DD_TRACE_STATS_*_CARDINALITY_LIMIT.
…lity-overflow # Conflicts: # tests/parametric/test_library_tracestats.py
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 8ec9af4 | Docs | Datadog PR Page | Give us feedback! |
ichinaski
changed the title
ichinaski
marked this pull request as ready for review
July 29, 2026 11:12
ichinaski
requested review from
ZStriker19,
avara1986,
jandro996,
mabdinur and
manuel-alvarez-alvarez
and removed request for
a team
July 29, 2026 11:12
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c47bdaf59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
nccatoni
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CSS Cardinality Limits require tracers to collapse excess stats cardinality into a
tracer_blocked_valueoverflow bucket instead of discarding it, keeping service-level totals intact. Nothing in system-tests covered this contract.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present