Validate jira ticket reason for manifest declarations in the parser to improve error clarity

[nccatoni]

Motivation

Changes

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added, removed or renamed?
  • Get a review from R&P team

[github-actions]

CODEOWNERS have been resolved as:

tests/test_the_test/manifests/manifests_agent_edit/agent.yml            @DataDog/system-tests-core
tests/test_the_test/test_decorators.py                                  @DataDog/system-tests-core
tests/test_the_test/test_easy_win.py                                    @DataDog/system-tests-core
tests/test_the_test/test_manifest.py                                    @DataDog/system-tests-core
utils/_decorators.py                                                    @DataDog/system-tests-core
utils/manifest/__init__.py                                              @DataDog/system-tests-core
utils/manifest/_internal/__init__.py                                    @DataDog/system-tests-core
utils/manifest/_internal/declaration.py                                 @DataDog/system-tests-core

[datadog-prod-us1-3]

 

⚠️ Warnings

🚦 2 Pipeline jobs failed

Testing the test | System Tests (python, prod) / parametric / parametric (1)     

🔄 Retry job. This looks flaky and may succeed on retry.

ImportError: cannot import name 'config' from partially initialized module 'ddtrace.internal.settings.asm' (most likely due to a circular import)

Testing the test | all-jobs-are-green     

See error

Some CI checks or statuses failed. Please check the summary table.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 0 passed on retry

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1f0f268 | Docs | Datadog PR Page | Give us feedback!}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 540cfb096a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Update the now-invalid agent manifest fixture

When Test_ComputeLibrariesAndScenarios.test_manifest_agent constructs Inputs, it parses tests/test_the_test/manifests/manifests_agent_edit/agent.yml, whose Test_SamplingRates entry is still the bare declaration bug. This new validation therefore raises ValueError before the test assertions, breaking that test and its CI suite; update the fixture to include a valid JIRA ticket alongside enforcing this invariant.

AGENTS.md reference: AGENTS.md:L33-L35

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Accept short Jira project keys

When a valid ticket has a one- or two-letter project key, such as AI-123, this pattern rejects the manifest with ValueError because it requires at least three letters. The repository's existing Jira validators and ticket-labeling script both define the accepted key as [A-Z]+-\d+ (tests/schemas/utils/schemas_validators.py and utils/scripts/add-system-tests-label-on-known-tickets.py), so this new parser check should use the same format rather than preventing otherwise valid bug and flaky declarations.

AGENTS.md reference: AGENTS.md:L24-L24

Useful? React with 👍 / 👎.