Skip to content

Adding back gitlab timeout because some jobs are hanging on the get_source step - #7423

Merged
nccatoni merged 1 commit into
mainfrom
nccatoni/gitlab-timeout2
Jul 31, 2026
Merged

Adding back gitlab timeout because some jobs are hanging on the get_source step#7423
nccatoni merged 1 commit into
mainfrom
nccatoni/gitlab-timeout2

Conversation

@nccatoni

Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

utils/ci/gitlab/system-tests.yml.j2                                     @DataDog/system-tests-core

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Jul 30, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

🚦 2 Pipeline jobs failed

Testing the test | System Tests (java, prod) / Build end-to-end (vertx4)   View in Datadog   GitHub Actions

See error Error resolving version for plugin 'org.codehaus.mojo:build-helper-maven-plugin' due to excessive requests. Status code: 429.

Testing the test | all-jobs-are-green   View in Datadog   GitHub Actions

See error Check run failed due to some CI checks or statuses failing. Please check the summary table for details.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 1 passed on retry View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2e7f9c4 | Docs | Datadog PR Page | Give us feedback!

@nccatoni
nccatoni marked this pull request as ready for review July 31, 2026 08:38
@nccatoni
nccatoni requested a review from a team as a code owner July 31, 2026 08:38
@nccatoni
nccatoni merged commit da43745 into main Jul 31, 2026
2055 of 2057 checks passed
@nccatoni
nccatoni deleted the nccatoni/gitlab-timeout2 branch July 31, 2026 08:38

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e7f9c4f95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

{% endfor %}
{% for variant, scenario, build_required in scenario_pairs %}
system_tests_run_{{library}}_{{scenario}}_{{variant}}:
timeout: 15 minutes

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Apply the hang timeout to every generated job

When get_sources hangs on a setup, build, or parametric job, this timeout has no effect because it is emitted only for jobs in scenario_pairs. The generated setup, system_tests_build_*, and system_tests_run_*_PARAMETRIC_* jobs all extend the same .system_tests_base, which does not define a timeout, so those jobs can still remain stuck until the broader project timeout. Apply the timeout at the shared/default level, or add it to every generated job category that can encounter the hanging runner phase.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant