Conversation
Python: - python-multipart: 0.0.20 -> 0.0.26 - pytest: 8.4.2 -> 9.0.3 - pytest-asyncio: 0.26.0 -> 1.3.0 - uv: 0.9.10 -> 0.11.7 npm (root + storybook): - ag-grid-community: ^35.2.0 -> ^35.2.1 - ag-grid-react: ^35.2.0 -> ^35.2.1 - import-in-the-middle: ^3.0.0 -> ^3.0.1 - @amplitude/analytics-core: ^2.44.1 -> ^2.45.0 - @types/node: ^25.5.0 -> ^25.6.0 - @vitest/coverage-v8: ^4.1.2 -> ^4.1.4 - postcss: ^8.5.8 -> ^8.5.9 - vitest: ^4.1.2 -> ^4.1.4 - @vitest/browser-playwright: ^4.1.2 -> ^4.1.4 - msw: ^2.12.14 -> ^2.13.2 @datarecce/ui dependency floors unchanged (consumer-facing). Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Kent Huang <kent@infuseai.io>
There was a problem hiding this comment.
Pull request overview
Consolidates multiple Dependabot updates into a single dependency refresh across the Python (uv/pytest stack) and JS (Next.js workspace) parts of the monorepo.
Changes:
- Updated Python dependency lockfile (
uv.lock) to newer versions ofpytest,pytest-asyncio,python-multipart, anduv(plus newly introduced transitive deps). - Updated JS lockfile (
js/pnpm-lock.yaml) to newer patch/minor versions for several frontend dependencies and test tooling. - Updated JS workspace
package.jsonfiles to reflect the bumped dependency ranges (root app, Storybook package, and UI package dev tooling).
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Bumps Python tool/test/runtime deps (notably pytest, pytest-asyncio, python-multipart, uv) and updates resolved artifacts. |
js/pnpm-lock.yaml |
Updates resolved dependency graph for the JS workspace after version bumps. |
js/packages/ui/package.json |
Updates UI package dev tooling version range for postcss. |
js/packages/storybook/package.json |
Bumps Storybook package testing/tooling deps (vitest, msw, vitest browser tooling). |
js/package.json |
Bumps root JS workspace deps/devDeps and aligns pnpm.overrides with the updated versions. |
Files not reviewed (1)
- js/pnpm-lock.yaml: Language not supported
Code Review — PR #1318SummaryDependency consolidation PR upgrading Python and frontend packages. Two critical issues found: pytest 9 breaks Findings[Critical] pytest 9 breaks
|
| Check | Result |
|---|---|
make test (python3 -m pytest tests) |
FAIL — collection error from dbt_packages |
pytest --ignore=dbt_packages |
PASS — 1061 passed |
pnpm test |
PASS — 3681 passed (153 files) |
pnpm lint (biome) |
PASS |
pnpm type:check (tsc) |
PASS |
make flake8 |
PASS |
Verdict
@datarecce/ui postcss floor bump should be reverted per project convention.
gcko
left a comment
There was a problem hiding this comment.
Claude Code Review: Critical issues found — pytest 9 breaks make test (collection error now fatal), and @datarecce/ui postcss floor was bumped against project convention. See review comment for details.
…tcss floor pytest 9 made collection errors fatal, breaking `make test` due to vendored dbt_packages. Add --ignore to pytest addopts. Revert postcss floor in @datarecce/ui from ^8.5.9 back to ^8.5.0 per project convention. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Jared Scott <jared.scott@datarecce.io>
Code Review — PR #1318SummaryDependency consolidation PR bumping 14 packages (4 Python, 10 npm) including two major Python version bumps (pytest 8→9, pytest-asyncio 0.26→1.3). All verification passes — no critical issues found. Antagonistic Review — Dependency Risk Analysispytest 8 → 9 (Major)The pytest-asyncio 0.26 → 1.3 (Major)This is the highest-risk change. The python-multipart 0.0.20 → 0.0.26Patch bump within 0.x range. This is a FastAPI dependency for multipart form parsing. Tests cover the API surface adequately — no runtime concerns. uv 0.9.10 → 0.11.7 (Major)Build/dev tool only — no runtime impact. Lock file regenerated cleanly. @datarecce/ui ImpactConfirmed: npm Minor/Patch Bumpsag-grid 35.2.0→35.2.1, vitest 4.1.2→4.1.4, msw 2.12→2.13, postcss 8.5.8→8.5.9 — all minor/patch. 3681 frontend tests pass, type-check clean, biome lint clean. Verification Results
Verdict✅ Approved — All dependency bumps are safe. Both major Python version jumps have been properly mitigated. No |
gcko
left a comment
There was a problem hiding this comment.
Claude Code Review: No critical issues found. All dependency bumps verified safe — full test suite green.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Summary
Consolidates the following Dependabot PRs into a single tested update:
Changes
Breaking change fixes
tests/adapter/dbt_adapter/test_proj/dbt_packages/dbt_utils/testsdirectory triggered aModuleNotFoundErrorthat was previously non-fatal in pytest 8 but now aborts test collection entirely. Fixed by addingaddopts = "--ignore=tests/adapter/dbt_adapter/test_proj/dbt_packages"to[tool.pytest.ini_options]inpyproject.toml.js/packages/ui/package.jsonfrom^8.5.9back to^8.5.0. The root lockfile still resolves to 8.5.10 via pnpm overrides — the floor bump was unnecessary and violated the convention of not bumping@datarecce/uidependency floors during Dependabot consolidation.@datarecce/ui Impact
No consumer-facing dependency changes. All
@datarecce/uidependency floors remain unchanged — the root lockfile resolves newer versions but consumers on existing minimum versions are unaffected.Test plan
🤖 Generated with Claude Code