Fix row details state restore: unescape escaped colons in row IDs#389
Open
MatrixNeoKozak wants to merge 1 commit into
Open
Fix row details state restore: unescape escaped colons in row IDs#389MatrixNeoKozak wants to merge 1 commit into
MatrixNeoKozak wants to merge 1 commit into
Conversation
Contributor
|
I might be being daft here, but is the new map function just undoing the escaping that the previous one is adding? Are you able to give me a link to a test case that shows the issue so I can dig into it as well please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in state restoration of child rows where colons in row IDs were not being unescaped after being escaped during state saving. The original code only escaped colons on save but did not unescape on load, causing the state to fail to restore child rows for IDs containing colons (e.g., 'a:b'). Added the reverse operation in detailsStateLoad to unescape the colon before passing to rows().