bundle type definitions for use analytics#389
Open
grumpyoldman-io wants to merge 2 commits intoDavidWells:masterfrom
Open
bundle type definitions for use analytics#389grumpyoldman-io wants to merge 2 commits intoDavidWells:masterfrom
grumpyoldman-io wants to merge 2 commits intoDavidWells:masterfrom
Conversation
grumpyoldman-io
force-pushed
the
51/bundle-type-definitions-for-use-analytics
branch
from
bb00702 to
4635e49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might not be my personal preferred way of adding types to a package, but at least it will bring some benefit to people using use-analytics.
#51 (comment)
This closes #51
I do recommend "connecting" the .js and .ts, and my suggestion is to convert
use-analyticsto TS, but this is against the wishes of the package maintainer. This is a very simple, but potentially fragile, upgrade.