loadIntegrations option to enable/disable loading of code for destinations in segment#500
Open
jasonbekolay wants to merge 1 commit intoDavidWells:masterfrom
Open
Conversation
jasonbekolay
force-pushed
the
segment/disable-destination-on-load
branch
from
19c7c5d to
2c69403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
integrationsconfig option will disable a destination that is configured in Segment, but the destination's code is still loaded. If you have a Segment destination and a plugin for this library configured for the same service, that will cause it to be loaded twice. In the case of Customer.io, this causes errors.The
loadIntegrationsoption added here allow you avoid this by disabling a Segment destination whenanalytics.loadis called.Thank you for this library and for reviewing my PR! I'm happy to integrate any feedback you may have.