Align Simple Form with the DOM-first runtime#204
Merged
Conversation
Update the Simple Form JavaScript hooks to match the jQuery-free ClientSideValidations runtime and stop assuming jQuery wrappers in the browser integration. SimpleForm::FormBuilder add/remove hooks now work with native DOM elements. Use closest(), querySelector(), parentElement, and classList to find wrappers and feedback nodes while preserving the existing error markup for the default, Bootstrap 4, and Bootstrap 5 builders. Refresh the QUnit coverage to build fixtures and assert behavior through plain DOM APIs, regenerate the published and vendored assets, switch the browser harness to a neutral QUnit CDN, and remove the remaining jQuery-specific assumptions from the test setup and documentation. Raise the compatibility floor to ClientSideValidations 24.x by requiring client_side_validations >= 24.0 in the gem, setting the npm peer dependency to @client-side-validations/client-side-validations >= 24.0.0, and updating the appraisal matrix to csv-24.0. Bump the gem and npm package versions to 18.0.0 for the release.
tagliala
force-pushed
the
experimental/remove-jquery
branch
from
74f3adf to
5f497e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Simple Form JavaScript hooks to match the jQuery-free ClientSideValidations runtime and stop assuming jQuery wrappers in the browser integration.
SimpleForm::FormBuilder add/remove hooks now work with native DOM elements. Use closest(), querySelector(), parentElement, and classList to find wrappers and feedback nodes while preserving the existing error markup for the default, Bootstrap 4, and Bootstrap 5 builders.
Refresh the QUnit coverage to build fixtures and assert behavior through plain DOM APIs, regenerate the published and vendored assets, switch the browser harness to a neutral QUnit CDN, and remove the remaining jQuery-specific assumptions from the test setup and documentation.
Raise the compatibility floor to ClientSideValidations 24.x by requiring client_side_validations >= 24.0 in the gem, setting the npm peer dependency to @client-side-validations/client-side-validations >= 24.0.0, and updating the appraisal matrix to csv-24.0. Bump the gem and npm package versions to 18.0.0 for the release.