Skip to content

Conversation

@reiase
Copy link
Contributor

@reiase reiase commented Jan 25, 2026

  • Removed deprecated methods from ActorSystemCoreExt and ActorSystemAdvancedExt to simplify the API.
  • Consolidated actor spawning logic into a single internal method, enhancing clarity and reducing redundancy.
  • Updated usage of actor spawning in tests and examples to utilize the new builder pattern for improved readability and maintainability.
  • Adjusted imports and module structure for better organization and consistency across the codebase.

Overview:

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

- Removed deprecated methods from `ActorSystemCoreExt` and `ActorSystemAdvancedExt` to simplify the API.
- Consolidated actor spawning logic into a single internal method, enhancing clarity and reducing redundancy.
- Updated usage of actor spawning in tests and examples to utilize the new builder pattern for improved readability and maintainability.
- Adjusted imports and module structure for better organization and consistency across the codebase.
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 87.71930% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/pulsing-actor/src/system/mod.rs 50.00% 4 Missing ⚠️
crates/pulsing-actor/src/system/spawn.rs 92.30% 2 Missing ⚠️
crates/pulsing-actor/src/system/traits.rs 95.65% 1 Missing ⚠️
Files with missing lines Coverage Δ
crates/pulsing-actor/src/test_helper.rs 86.66% <ø> (ø)
crates/pulsing-actor/src/system/traits.rs 51.19% <95.65%> (+9.37%) ⬆️
crates/pulsing-actor/src/system/spawn.rs 96.80% <92.30%> (-0.37%) ⬇️
crates/pulsing-actor/src/system/mod.rs 69.33% <50.00%> (-0.81%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants