Open
Conversation
b57f185 to
47b1fb8
Compare
47b1fb8 to
50ba63c
Compare
ssx
approved these changes
Jul 18, 2025
src/BuilderIOProductCollections/Block/Adminhtml/ProductCollection/Edit/Tab/Conditions.php
Show resolved
Hide resolved
314cbe7 to
29b8d65
Compare
29b8d65 to
a9e2d37
Compare
Open
mugureltanase
approved these changes
Jul 28, 2025
a9e2d37 to
f22ec09
Compare
ssx
approved these changes
Aug 18, 2025
Member
|
Hey @brandon-deploy 👋 a couple of things I spotted:
|
Collaborator
Author
|
Hi @nathanchick I have fixed the issues. The chooser (category id's form component thing) was expecting to be in a fieldset called rule_condition_fieldset due it being the same one from the catalog_rule module. |
I haven't tested this yet
Collaborator
Author
|
Hi @nathanchick, I've split the modules as requested. I've also fixed a few things. As far as functionality goes, I think this is ready to go. let me know if you spot anything your side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
Changes I have made:
I couldn't get the forms to conditionally hide. Though, my best attempt is still there within the UI component if anyone want to give it a shot.
Contribution checklist