Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new local option to override the SSE endpoint host/base URI used for realtime updates, allowing SSE traffic to be routed through a proxy or alternate hostname.
Changes:
- Introduces
DevCycleLocalOptions.SseUri(and constructor parameter) to override the SSE hostname/base URI. - Updates
EnvironmentConfigManagerto use the override when constructing the SSE URL. - Adds new
usingdirectives in the example program (currently unused).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| DevCycle.SDK.Server.Local/ConfigManager/EnvironmentConfigManager.cs | Builds SSE URL using SseUri override when provided. |
| DevCycle.SDK.Server.Common/Model/Local/DevCycleLocalOptions.cs | Adds SseUri option + constructor parameter and XML documentation. |
| DevCycle.SDK.Server.Local.Example/Program.cs | Adds using System.Net; / using System.Text; imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var sseHostname = !string.IsNullOrEmpty(localOptions.SseUri) | ||
| ? localOptions.SseUri | ||
| : sseProp.GetProperty("hostname").GetString(); | ||
| var sseUri = sseHostname + sseProp.GetProperty("path").GetString(); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a new local SDK option to override the SSE host/URI used for realtime updates, allowing consumers to route SSE traffic through a different hostname (e.g., a proxy) while still using the config-provided SSE path.
Changes:
- Introduced
SseUrionDevCycleLocalOptionsto override the SSE hostname/base URI. - Updated
EnvironmentConfigManagerto preferlocalOptions.SseUriwhen constructing the SSE endpoint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| DevCycle.SDK.Server.Local/ConfigManager/EnvironmentConfigManager.cs | Uses the new option when building the SSE URL for SSEManager. |
| DevCycle.SDK.Server.Common/Model/Local/DevCycleLocalOptions.cs | Adds the new SseUri option and wires it through the constructor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| var sseHostname = !string.IsNullOrEmpty(localOptions.SseUri) | ||
| ? localOptions.SseUri | ||
| : sseProp.GetProperty("hostname").GetString(); | ||
| var sseUri = sseHostname + sseProp.GetProperty("path").GetString(); |
Changes