Fluent-next: extract css variables of components level - #34888
Open
EugeniyKiyashko wants to merge 17 commits into
Open
Conversation
…e's numbered parameters (DevExpress#34742)
…ss#34744) Co-authored-by: Andrei Kharitonov <pharret31@users.noreply.github.com>
…, fix hardcoded colors in Widget Gallery (DevExpress#34698) Co-authored-by: Andrei Kharitonov <pharret31@users.noreply.github.com> Co-authored-by: EugeniyKiyashko <EugeniyKiyashko@users.noreply.github.com>
Rebase onto main brought the adduse/dead-import rules; fluent-next was written before them. Removes 257 adduse markers and 141 dead theme-root imports (27 files become empty placeholders), plus the formatting fixes the new @Stylistic rules require.
The rebase took main's lockfile to avoid a hand-merge; re-adding the branch's devextreme-scss devDependencies is what pnpm regenerates.
They were unrelated to the theme: 13 workflows had gained a `push: branches: [26_1]` trigger (default_workflow a `[0-9][0-9]_[0-9]` glob, wrapper_tests_e2e a `26_*` entry). The fluent-next additions to the testcafe and demo visual-test matrices stay.
pharret31
reviewed
Aug 24, 2026
| $grid-command-edit-text-margin: ds.$spacing-20 !default; | ||
|
|
||
| // Общий на все гриды: base рисует фокус-кольцо кнопки AI-колонки правилом БЕЗ скоупа виджета (одинаковый селектор в base/dataGrid и base/treeList), поэтому значение обязано резолвиться в любом гриде — имя живёт в gridBase, а не в dataGrid/treeList (F15) | ||
| $grid-outline-focused: ds.$spacing-20 solid !default; |
Contributor
There was a problem hiding this comment.
Why here and in other places not a --dx- variables? Also comment
pharret31
reviewed
Aug 24, 2026
| &.dx-texteditor-with-label, | ||
| &.dx-texteditor-with-floating-label { | ||
| .dx-texteditor-label { | ||
| width: calc(100% + 2 * $text-editor-border-width); |
Contributor
There was a problem hiding this comment.
Don't we have a variable for this?
pharret31
reviewed
Aug 24, 2026
Comment on lines
+1775
to
+1777
| "!{projectRoot}/artifacts/css/dx.*.css", | ||
| "!{projectRoot}/artifacts/css/fonts/**", | ||
| "!{projectRoot}/artifacts/css/icons/**", |
Contributor
There was a problem hiding this comment.
As far as I see in NX docs outputs don't support exclamation mark syntax, why it was added here and in other places?
Feels like it doesn't make sense
https://nx.dev/docs/kb/configure-outputs
EugeniyKiyashko
force-pushed
the
feature/26_2_new_fluent_theme_with_design_tokens
branch
from
August 25, 2026 11:59
3e93edd to
463e0df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.