refactor(rdpeusb): eliminate repetition#1407
Merged
Benoît Cortier (CBenoit) merged 1 commit intoJul 7, 2026
Merged
Conversation
folow-ups to Devolutions#1365: https://github.com/Devolutions/IronRDP/pull/1365/changes#r3487982872 Signed-off-by: uchouT <i@uchout.moe>
There was a problem hiding this comment.
Pull request overview
This PR refactors ironrdp-rdpeusb’s UrbdrcDeviceClient to reduce repetition around pending I/O tracking and completion-message construction, following up on feedback from #1365.
Changes:
- Consolidates repeated “is this request acceptable?” checks into
accepts_io_request. - Replaces the
Pendingenum withPendingKind+Pendingstruct and centralizes completion lookup viapending_completion. - Extracts shared completion construction into
build_*_completionhelpers and reuses them across immediate and deferred completion paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Benoît Cortier (CBenoit)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
folow-ups to #1365:
https://github.com/Devolutions/IronRDP/pull/1365/changes#r3487982872