Injecting default parameters values into output yaml and copy distortion coefficients file#713
Injecting default parameters values into output yaml and copy distortion coefficients file#713
Conversation
yousefmoazzam
left a comment
There was a problem hiding this comment.
Looks reasonable, thanks!
One note: the feature of putting the default values used into the copied YAML pipeline probably is something we want to include in the "user release notes", so adding the associated label to the PR would make sense.
Connected to this is the fact that this PR also includes the distortion coefficient file copy change, which I also think would make sense as a "user release note". However, the PR title is what appears in the user release notes, and the current PR title doesn't mention the distortion coefficients file copy change.
If the distortion coefficients file copy change is going to be in the same PR as the default values injection change, then I think this PR name should be changed to reflect that, so then the distortion coefficients file copy change isn't missed from the user release notes.
Fixes issue and issue
Issue: When default parameters are omitted in the original YAML pipeline, they are not propagated to the resulting output YAML file.
Resolution (with some caveats):
I've added also distortion correction bit here as it is a small change but it affects the same part in cli.py. Hope its OK.
Checklist
user-release-notelabel in order to include this PR in the "NotableChanges for Users" section in release notes