Skip to content

feat: add maxAliasCount option to parse function for improved Docker …#3930

Merged
Siumauricio merged 1 commit intocanaryfrom
3924-docker-composeyml-excessive-alias-count-indicates-a-resource-exhaustion-attack
Mar 7, 2026
Merged

feat: add maxAliasCount option to parse function for improved Docker …#3930
Siumauricio merged 1 commit intocanaryfrom
3924-docker-composeyml-excessive-alias-count-indicates-a-resource-exhaustion-attack

Conversation

@Siumauricio
Copy link
Contributor

@Siumauricio Siumauricio commented Mar 7, 2026

…Compose file handling

What is this PR about?

Please describe in a short paragraph what this PR is about.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

closes #3924

Screenshots (if applicable)

Greptile Summary

This PR adds maxAliasCount: 10000 to three yaml.parse() call sites in Docker Compose file handling, fixing a parsing failure for files that exceed the library's default 100-alias limit. The change is minimal, targeted, and correctly addresses the referenced issue (#3924).

Confidence Score: 5/5

  • This PR is safe to merge. It applies a single, well-understood configuration option to three YAML parsing call sites to fix a legitimate issue with Compose files that exceed the default alias limit.
  • The change is minimal and correct. It adds maxAliasCount: 10000 to three yaml.parse() calls, directly addressing the reported issue where legitimate Docker Compose files fail to parse due to exceeding the default 100-alias limit. The modification is straightforward with no side effects or functional regressions. The code change logic is trivially correct.
  • No files require special attention. Both modified files contain straightforward, correct implementations of the fix.

Last reviewed commit: 076262e

Context used:

  • Rule used - AGENTS.md (source)

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 7, 2026
@Siumauricio Siumauricio merged commit 95e14b4 into canary Mar 7, 2026
5 checks passed
@Siumauricio Siumauricio deleted the 3924-docker-composeyml-excessive-alias-count-indicates-a-resource-exhaustion-attack branch March 7, 2026 23:44
@dosubot dosubot bot added the enhancement New feature or request label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker-compose.yml: Excessive alias count indicates a resource exhaustion attack

1 participant