Add curl timeout and retry flags to prevent install script hangs#517
Open
enescakir wants to merge 1 commit intoDopplerHQ:masterfrom
Open
Add curl timeout and retry flags to prevent install script hangs#517enescakir wants to merge 1 commit intoDopplerHQ:masterfrom
enescakir wants to merge 1 commit intoDopplerHQ:masterfrom
Conversation
The curl command in curl_download() had no connect-timeout or max-time set, causing it to hang indefinitely on slow/stalled connections. The --retry 5 flag was ineffective because curl never timed out on its own to trigger a retry. Added: - --connect-timeout 10: fail fast if server is unreachable - --max-time 60: cap total transfer time per attempt - --retry-all-errors: retry on all errors, not just transient ones Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
+1 This would be very helpful for us. We regularly run into ETIMEDOUT errors, making CI fail. |
Contributor
|
Hey @enescakir, I've reviewed and tested this and this all looks good. Could you please remove claude as a co-author for the commit? Once that's done, I'll approve this and get it merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curl command in curl_download() had no connect-timeout or max-time set, causing it to hang indefinitely on slow/stalled connections. The --retry 5 flag was ineffective because curl never timed out on its own to trigger a retry.
The
dopplerhq/cli-actionaction has 30 seconds timeout, so it occasionally fails without retry.Added: