Moves pointers to local vs module-level (makes them private to threads) - #1651
Open
briandobbins wants to merge 1 commit into
Open
Moves pointers to local vs module-level (makes them private to threads)#1651briandobbins wants to merge 1 commit into
briandobbins wants to merge 1 commit into
Conversation
briandobbins
requested review from
cacraigucar and
nusbaume
and removed request for
nusbaume
August 17, 2026 20:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seemed like a simpler choice than declaring them threadprivate.
I have not run the CAM test suite, just a single FHISTC_MTt4s case that I'm benchmarking threads in. There will be a few more PRs related to threading incoming, and I figure we can test them all together, as each is pretty small. My test against an unchanged CAM was bit-for-bit.
Partially address #1650
Once all are in, we can close the issue.