Add fixes suggested by DeepSeek #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-no-dev
force-pushed
the
improvement/deepseek
branch
from
5add560 to
42adde4
Compare
mathieucarbou
previously approved these changes
Jan 27, 2025
me-no-dev
force-pushed
the
improvement/deepseek
branch
from
6116e24 to
335b362
Compare
mathieucarbou
dismissed
their stale review
Client.ini does not work anymore with the current changes.
me-no-dev
force-pushed
the
improvement/deepseek
branch
from
3729ae7 to
1bbd5aa
Compare
mathieucarbou
force-pushed
the
improvement/deepseek
branch
from
1bbd5aa to
8210523
Compare
mathieucarbou
requested review from
a team
and removed request for
mathieucarbou
mathieucarbou
approved these changes
Jan 28, 2025
Member
mathieucarbou
left a comment
mathieucarbou
left a comment
There was a problem hiding this comment.
Changes as of now do work with Client.ino and espasyncws (ran sse, ws and http perf tests)
mathieucarbou
approved these changes
Jan 28, 2025
Member
mathieucarbou
left a comment
mathieucarbou
left a comment
There was a problem hiding this comment.
tested Client.ino again - no issue :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.