Fix filter labels not translated with correct domain#7520
Open
Amoifr wants to merge 1 commit intoEasyCorp:5.xfrom
Open
Fix filter labels not translated with correct domain#7520Amoifr wants to merge 1 commit intoEasyCorp:5.xfrom
Amoifr wants to merge 1 commit intoEasyCorp:5.xfrom
Conversation
Filter labels were not being translated the same way as on other CRUD pages because the label was passed as a plain string while filters use translation_domain 'EasyAdminBundle'. Now CommonConfigurator: - Preserves TranslatableInterface labels from fields - Wraps string labels in t() with the application's translation domain Fix EasyCorp#7373
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommonConfiguratorpassed plain strings as labels, but filters usetranslation_domain: EasyAdminBundlecommand.label.lastRunAtto be looked up inEasyAdminBundledomain instead of the application's domainChanges:
TranslatableInterfacelabels from fields instead of extracting the messaget()with the application's translation domain from$context->getI18n()->getTranslationDomain()Test plan
CommonConfiguratorTranslatableInterfaceFix #7373