-
Notifications
You must be signed in to change notification settings - Fork 5
chore: overhaul releasing workflow, supported frameworks #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| runs-on: windows-2022 | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| with: | ||
| submodules: true | ||
|
|
||
| - name: Install .NET SDK | ||
| uses: actions/setup-dotnet@v5 | ||
| id: setupid | ||
| with: | ||
| dotnet-version: 10.x.x | ||
|
|
||
| - name: Specify .NET SDK version to use since GitHub runners have multiple installed | ||
| run: | | ||
| echo '{"sdk":{"version": "${{ steps.setupid.outputs.dotnet-version }}"}}' > ./global.json | ||
| - name: Setup MSBuild | ||
| uses: microsoft/setup-msbuild@v2 | ||
|
|
||
| - name: Setup Nuget | ||
| uses: NuGet/setup-nuget@v2 | ||
|
|
||
| - name: Setup VSTest | ||
| uses: darenm/[email protected] | ||
|
|
||
| # Pull in fixtures submodule | ||
| - name: Set up dotnet tools and dependencies | ||
| run: make install | ||
|
|
||
| - name: Restore NuGet Packages | ||
| run: make restore build | ||
|
|
||
| # Run the compatibility tests | ||
| - name: Run Tests | ||
| run: make netstandard-compat-test FW=net472 | ||
|
|
||
| FSharp_Compatibility: | ||
| FSharp_Compatibility_Tests: |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 21 days ago
To fix this issue, we should add a permissions block specifying the minimal required permissions for all jobs. The CodeQL suggestion for a minimal starting point is contents: read. The best way to implement this is to add a permissions: section at the root level of the workflow, before the jobs: block. This will ensure all jobs inherit these limited permissions unless overridden at the job level. No other workflow functionality will be affected by limiting permissions to read-only, so this change is safe and applies across all jobs as a best practice.
Changes needed:
- Edit
.github/workflows/ci.yml. - Insert the following block after the workflow name (line 2 or 3), before the
on:block:permissions: contents: read - No additional imports, methods, or definitions are required; this is a declarative change in a YAML file.
-
Copy modified lines R3-R4
| @@ -1,5 +1,7 @@ | ||
| name: CI | ||
|
|
||
| permissions: | ||
| contents: read | ||
| on: | ||
| push: | ||
| branches: [master] |
Description
EasyPosttoEasyVCR).Testing
All CI tests pass.
Pull Request Type
Please select the option(s) that are relevant to this PR.