Support Gradle 9 #30
Open
Support Gradle 9 #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To the latest version which still works on Gradle 8.8.
The space-to-assign (`url ""` being equal to `url = ""`) Groovy syntax is being deprecated, so while we have to touch all these lines, we may as well centralize all repos into the `settings.gradle.kts` file.
Projects for which the folder does not exist are deprecated.
Relying on automatic test framework implementation dependencies is deprecated.
Access to `project` during task execution is incompatible with the Configuration Cache feature which is enabled by default with Gradle 9.
Because `Task`, which is referenced from `TaskOutputs`, isn't serializable as far as the Configuration Cache is concerned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various deprecated things in an effort to make the repo build with Gradle 9.
See individual commits for details.
This is required because Minecraft 26.1 requires Java 25 which requires Gradle 9, and Essential
includeBuilds this repo, and therefore will require it to be compatible with Gradle 9.This PR does not yet upgrade the Gradle used by this repository, because we still want it to remain compatible with Gradle 8 (at least until Essential upgrades to Gradle 9).
These changes do not affect the produced jars (they are bit-for-bit identical to the jars produced prior to these changes), with one exception: The
container-modlauncher{8,9}.jarfiles (both produced by the Shadow plugin) are not bit-for-bit identical because it seems the newer Shadow plugin now uses the 2.0 ZIP spec, while the old one used the 1.0 spec. Their content appears identical though.