Open
Conversation
…er lines The top border, header/data separator, and last-row bottom border are rendered as plain strings (not lipgloss styles) to work around lipgloss v2 Width() semantics. This means BorderForeground set via WithBaseStyle has no effect on them. WithBorderForeground(color.Color) stores the colour on the Border struct and applies it via lipgloss.NewStyle().Foreground().Render() in buildBorderLine, making all border lines consistently coloured.
inkel
approved these changes
Apr 22, 2026
Contributor
inkel
left a comment
inkel
left a comment
There was a problem hiding this comment.
FWIW LGTM. Thank you for your effort, @wheelibin !!! I really hope this gets merged and I can remove the hacks I've made for upgrading my app to the latest Bubble Tea version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Evertras
This PR updates the charm libraries to v2 following the official upgrade guide.
I updated my app to bubbletea V2 and then needed bubble-table (which I heavily rely on) to also be updated.
I created a fork for this purpose and I'm currently using that, however I'd prefer to contribute this back if possible and drop my fork.
Relevant issues: #194 #216
Cheers!