Skip to content

Hide the chat history when Concierge is opened up in the right hand pane#81807

Open
Krishna2323 wants to merge 20 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/81587
Open

Hide the chat history when Concierge is opened up in the right hand pane#81807
Krishna2323 wants to merge 20 commits intoExpensify:mainfrom
Krishna2323:krishna2323/issue/81587

Conversation

@Krishna2323
Copy link
Contributor

@Krishna2323 Krishna2323 commented Feb 8, 2026

Explanation of Change

Fixed Issues

$ #81587
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…ane.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…ane.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@melvin-bot
Copy link

melvin-bot bot commented Feb 8, 2026

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...report/ReportActionCompose/ReportActionCompose.tsx 69.13% <ø> (-0.23%) ⬇️
src/pages/inbox/report/ReportFooter.tsx 51.06% <100.00%> (+0.52%) ⬆️
src/pages/inbox/report/ReportActionsList.tsx 75.73% <87.50%> (-0.01%) ⬇️
src/pages/inbox/ReportScreen.tsx 67.05% <78.57%> (+0.38%) ⬆️
src/components/ConciergeSidePanelWelcome.tsx 0.00% <0.00%> (ø)
src/pages/inbox/report/ReportActionsView.tsx 76.39% <90.90%> (+5.45%) ⬆️
... and 145 files with indirect coverage changes

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323 Krishna2323 changed the title Krishna2323/issue/81587 Hide the chat history when Concierge is opened up in the right hand pane Feb 11, 2026
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Copy link
Contributor Author

Krishna2323 commented Feb 11, 2026

@marcaaron Do we still need to show the welcome header after the user has sent a message? I don’t have the design implementation details, so I’m a bit confused.

image
Monosnap.screencast.2026-02-12.03-12-17.mp4

@marcaaron
Copy link
Contributor

From the original issue:

After user sends a message
The canned welcome message disappears (no longer rendered).

@Krishna2323
Copy link
Contributor Author

Sorry for the confusion — I’m referring to the regular welcome header that appears just before the first message. Should this always be displayed, or only when the user scrolls to the top of the chat after loading older messages? Could you please check the outcome video here?

image

@marcaaron
Copy link
Contributor

I think probably the original CREATE action should be hidden entirely in the RHP at first?

We can rely on the programatic one instead that will hide after a user leaves a comment.

@Krishna2323 Krishna2323 marked this pull request as ready for review February 13, 2026 16:31
@Krishna2323 Krishna2323 requested review from a team as code owners February 13, 2026 16:31
@melvin-bot melvin-bot bot requested review from heyjennahay and parasharrajat and removed request for a team February 13, 2026 16:31
@melvin-bot
Copy link

melvin-bot bot commented Feb 13, 2026

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team February 13, 2026 16:31
@Krishna2323
Copy link
Contributor Author

@Expensify/design could you please take a look at the outcome of the changes? Thanks!

Monosnap.screencast.2026-02-12.03-12-17.mp4

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0975dd4cea

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@shawnborton
Copy link
Contributor

Hmm it seems like this doesn't match the original mockup?

CleanShot 2026-02-13 at 17 55 07@2x

@Krishna2323
Copy link
Contributor Author

@marcaaron @shawnborton Is this really a design mock? I initially assumed it was just a reference to help indicate the component structure, since there isn’t anything visually similar to what’s described in the OP.

Could you please confirm what the expected design should be? I’m a bit confused about the intended direction here.

@shawnborton
Copy link
Contributor

Yes, that is indeed a design mock :)

@parasharrajat
Copy link
Member

@Krishna2323 is this ready?

@marcaaron
Copy link
Contributor

@Krishna2323 Let us know if there are any other blockers. This one is a high priority for the Concierge AI initiative so would be good to get merged soon!

@Krishna2323
Copy link
Contributor Author

Started working on it, will try to make this ready for review in an hour or two.

@parasharrajat
Copy link
Member

Thanks, I will check it in the evening.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Copy link
Contributor Author

@Expensify/design 👀 please

Monosnap.screencast.2026-02-19.10-05-55.mp4

@shawnborton
Copy link
Contributor

Why is this screen being displayed here?
CleanShot 2026-02-19 at 07 46 12@2x

The idea is that as soon as you open up the Concierge RHP, you see this:
image

@Krishna2323
Copy link
Contributor Author

Krishna2323 commented Feb 19, 2026

Show a canned welcome message (virtual / frontend-only) like “Hi there, I'm Concierge. How can I help?” each time it opens

2. Create ConciergeSidePanelWelcome Component

Create new component at src/components/ConciergeSidePanelWelcome.tsx:

  • Display Concierge avatar
  • Show greeting message from translations
  • Use existing styling patterns from ReportWelcomeText.tsx
  • Conditionally, hide once user sends first message

5. Conditionally Render Welcome Message

In ReportActionsView.tsx or ReportActionsList.tsx:

  • When isConciergeSidePanel && !hasUserSentMessage && !showFullHistory:

    • Render ConciergeSidePanelWelcome component instead of/before the message list
    • Hide the ListFooterComponent skeleton loader
  • When hasUserSentMessage:

    • Hide ConciergeSidePanelWelcome
    • Show messages from current session only

@shawnborton I’m still a bit confused about where this would actually be shown. Could you clarify where this component is expected to appear?

@shawnborton
Copy link
Contributor

The mock above would be shown as soon as you open up the Concierge RHP.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323
Copy link
Contributor Author

@Expensify/design please take a look again 🙏🏻

Few questions:

  • Do we need to show the "Show history" button all the time?
  • Should there be some temporary comment from the concierge each time the chat is opened?
Monosnap.screencast.2026-02-20.12-21-11.mp4

@shawnborton
Copy link
Contributor

Do we need to show the "Show history" button all the time?
Should there be some temporary comment from the concierge each time the chat is opened?

Can you try it quickly with both of those? Maybe the temporary message is simply "Hi there, how can I help?"

@Krishna2323
Copy link
Contributor Author

@shawnborton The temporary message disappears once we load the history. Is that fine, or should we retain it for the entire session?

Monosnap.screencast.2026-02-20.12-58-39.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@shawnborton
Copy link
Contributor

That seems reasonable to me, let's see what the others think too though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments