fix: device back button doesn't close FAB menu#82977
fix: device back button doesn't close FAB menu#82977daledah wants to merge 2 commits intoExpensify:mainfrom
Conversation
|
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd38317347
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (!(window.history.state as WindowState)?.shouldGoBack) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Remove modal guard entry after deferred navigation check
This early return skips history.back() whenever a menu action has already navigated, but those actions typically use Navigation.navigate, which pushes a new browser entry by default (src/libs/Navigation/helpers/linkTo/index.ts:159-161). That means the synthetic shouldGoBack entry created when the modal opened is never popped, so the history stack keeps an extra duplicate route and users need an extra Back press (or appear to go back to the same page) after navigating from the FAB menu.
Useful? React with 👍 / 👎.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Explanation of Change
Fixed Issues
$ #70951
#81239
PROPOSAL: #70951 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov
Screen.Recording.2026-02-20.at.00.36.10.mov