IOU - Rate field disabled if destination is self DM and no workspace during manual track distance by lorretheboy · Pull Request #82987 · Expensify/App

lorretheboy · 2026-02-19T18:37:59Z

Explanation of Change

Fixed Issues

$ #82594
PROPOSAL: #82594 (comment)

Tests

Precondition:

The user does not have workspace
User have Self-DM

Navigate to staging.new.expensify.com
Click the + global create button, select "Track Distance", and go to the "Manual" tab
Enter a valid distance and click "Next"
Select the user’s email address(Personal) as the recipient
Verify that "Rate" option row in confirm page should be clickable & clicking on it should display the Upgrade page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

website.android.mov

iOS: Native

Will update ASAP once I resolve iOS offline issue

iOS: mWeb Safari

website.ios.mov

MacOS: Chrome / Safari

website.mov

…uring manual track distance

melvin-bot · 2026-02-19T19:01:10Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-02-19T19:04:56Z

src/components/MoneyRequestConfirmationListFooter.tsx

                <MenuItemWithTopDescription
                    key={translate('common.rate')}
-                    shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && !isUnreported}
+                    shouldShowRightIcon={!!rate && !isReadOnly && iouType !== CONST.IOU.TYPE.SPLIT && (!isUnreported || isTrackExpense)}


❌ CONSISTENCY-3 (docs)

The boolean expression \!\!rate && \!isReadOnly && iouType \!== CONST.IOU.TYPE.SPLIT && (\!isUnreported || isTrackExpense) is duplicated identically on both the shouldShowRightIcon (line 554) and interactive (line 582) props. If this condition ever needs to change, both locations must be updated in sync, which is error-prone.

Extract it into a descriptive variable:

const isRateInteractive = \!\!rate && \!isReadOnly && iouType \!== CONST.IOU.TYPE.SPLIT && (\!isUnreported || isTrackExpense);

Then use it in both props:

shouldShowRightIcon={isRateInteractive} // ... interactive={isRateInteractive}

Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

NAB: @lorretheboy The suggestion to create a new variable in this case makes sense, since the value is the same.

Fixed @suneox

suneox · 2026-02-20T05:53:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

CleanShot.2026-02-20.at.12.48.46.4.mp4

Android: mWeb Chrome

CleanShot.2026-02-20.at.12.50.08.5.mp4

iOS: HybridApp

CleanShot.2026-02-20.at.12.45.51.2.mp4

iOS: mWeb Safari

CleanShot.2026-02-20.at.12.48.03.3.mp4

MacOS: Chrome / Safari

CleanShot.2026-02-20.at.12.42.29.1.mp4

joekaufmanexpensify

Good for product

github-actions · 2026-02-23T16:03:02Z

🚧 @dangrous has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-23T16:08:51Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #82987.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9e12125-08338eb-dcfabce0c3332c6a8d570fd85d35a211b2ffac88/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9e12125-08338eb-67ab6d4dd02b5bf2e1035bea9eddce420de8fb0b/index.html

Web 🕸️
https://82987.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-23T16:09:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-24T01:18:56Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	cancelled 🔪

This reverts commit 9e12125, reversing changes made to 3cad1f6.

Revert "Merge pull request #82987 from lorretheboy/fix/82594"

Revert "Merge pull request #82987 from lorretheboy/fix/82594" (cherry picked from commit 9f8b054) (cherry-picked to staging by puneetlath)

OSBotify · 2026-02-25T15:52:30Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.25-13 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-25T18:26:10Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.3.26-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-02-27T14:57:30Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.3.26-8 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Rate field disabled if destination is self DM and no workspace d…

922e1ca

…uring manual track distance

melvin-bot bot assigned lorretheboy Feb 19, 2026

lorretheboy added 2 commits February 20, 2026 01:39

fix: Rate field disabled if destination is self DM and no workspace d…

c82fd07

…uring manual track distance

fix: Rate field disabled if destination is self DM and no workspace d…

19c7aa7

…uring manual track distance

lorretheboy marked this pull request as ready for review February 19, 2026 19:01

lorretheboy requested review from a team as code owners February 19, 2026 19:01

melvin-bot bot requested review from joekaufmanexpensify and suneox and removed request for a team February 19, 2026 19:01

melvin-bot bot removed the request for review from a team February 19, 2026 19:01

lorretheboy mentioned this pull request Feb 19, 2026

IOU - Rate field disabled if destination is self DM and no workspace during manual track distance #82594

Open

7 tasks

github-actions bot reviewed Feb 19, 2026

View reviewed changes

lorretheboy added 2 commits February 21, 2026 01:12

Merge branch 'main' of https://github.com/Expensify/App into fix/82594

dfa48cd

fix: refactor

4a60919

joekaufmanexpensify approved these changes Feb 20, 2026

View reviewed changes

suneox approved these changes Feb 20, 2026

View reviewed changes

melvin-bot bot requested a review from dangrous February 20, 2026 22:21

dangrous approved these changes Feb 23, 2026

View reviewed changes

dangrous merged commit 9e12125 into Expensify:main Feb 23, 2026
32 checks passed

OSBotify mentioned this pull request Feb 23, 2026

Deploy Checklist: New Expensify 2026-02-23 #83247

Closed

mitarachim mentioned this pull request Feb 23, 2026

[$250] Expense - RHP back button reopens confirm page after creating workspace via Rate field #83265

Closed

7 tasks

dangrous added a commit that referenced this pull request Feb 24, 2026

Revert "Merge pull request #82987 from lorretheboy/fix/82594"

554ce62

This reverts commit 9e12125, reversing changes made to 3cad1f6.

puneetlath added a commit that referenced this pull request Feb 24, 2026

Merge pull request #83355 from Expensify/dangrous-revert82987

9f8b054

Revert "Merge pull request #82987 from lorretheboy/fix/82594"

OSBotify pushed a commit that referenced this pull request Feb 24, 2026

Merge pull request #83355 from Expensify/dangrous-revert82987

102056a

Revert "Merge pull request #82987 from lorretheboy/fix/82594" (cherry picked from commit 9f8b054) (cherry-picked to staging by puneetlath)

Conversation

lorretheboy commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 19, 2026

Uh oh!

github-actions bot Feb 19, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-3 (docs)

Uh oh!

suneox Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

lorretheboy Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

suneox commented Feb 20, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

OSBotify commented Feb 23, 2026

Uh oh!

OSBotify commented Feb 24, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 25, 2026

Uh oh!

OSBotify commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lorretheboy commented Feb 19, 2026 •

edited

Loading