[No QA] Fix prettier import sorting broken by @prettier/plugin-oxc by roryabraham · Pull Request #83008 · Expensify/App

roryabraham · 2026-02-19T22:22:45Z

Explanation of Change

PR #82351 added @prettier/plugin-oxc for ~5x faster formatting, but it broke automatic import sorting. The OXC plugin registers oxc and oxc-ts parsers that override Prettier's built-in babel and typescript parsers for JS/TS files. Since @trivago/prettier-plugin-sort-imports only attaches its import-sorting preprocess hook to the babel/typescript/flow/vue parsers, import sorting was silently skipped.

This PR:

Upgrades @trivago/prettier-plugin-sort-imports from 5.2.2 to 6.0.2 (the latest)
Patches it to add oxc and oxc-ts parser entries that compose OXC's parser with the sort-imports defaultPreprocessor (the import is wrapped in try/catch so @prettier/plugin-oxc remains optional)
Re-runs prettier to fix import ordering in ~65 files that drifted while sorting was broken

Fixed Issues

$ #82687

Tests

Create a .ts file with deliberately out-of-order imports (e.g. @src/ before @components/)
Run npx prettier --experimental-cli --write <file>
Verify imports are reordered according to the importOrder config in .prettierrc.js
Run npx prettier --experimental-cli --check . and verify all files pass

Verify that no errors appear in the JS console

Offline tests

N/A - this is a dev tooling change only.

QA Steps

// [No QA] - dev tooling change only, no runtime impact.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A - dev tooling change only

Android: mWeb Chrome

N/A - dev tooling change only

iOS: Native

N/A - dev tooling change only

iOS: mWeb Safari

N/A - dev tooling change only

MacOS: Chrome / Safari

N/A - dev tooling change only

Made with Cursor

melvin-bot · 2026-02-19T22:22:51Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Upgrade @trivago/prettier-plugin-sort-imports from 5.2.2 to 6.0.2 and patch it to support the oxc and oxc-ts parsers registered by @prettier/plugin-oxc. Without this patch, import sorting is silently skipped because the sort-imports plugin only attaches its preprocess hook to the babel/typescript/flow/vue parsers, not the OXC parsers that now handle JS/TS files. The patch adds oxc and oxc-ts parser entries that compose OXC's parser with the sort-imports defaultPreprocessor. The import of @prettier/plugin-oxc is wrapped in try/catch so it remains optional. Also runs prettier to fix import ordering in 65 files that drifted while the sorting was broken. Co-authored-by: Cursor <cursoragent@cursor.com>

- Map parse-imports-exports to its CJS entry in Jest moduleNameMapper to work around Jest VM module linker failing to resolve named ESM exports - Restore blank line after import statements in test expectations, which the sort-imports preprocessor adds when it processes imports Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 598c9313d2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-02-20T22:18:58Z

jest/setup.ts

 import type Animated from 'react-native-reanimated';
 import 'setimmediate';
 import * as MockedSecureStore from '@src/libs/MultifactorAuthentication/Biometrics/SecureStore/index.web';
+import '@src/polyfills/PromiseWithResolvers';


Restore PromiseWithResolvers import to top of setup file

Moving @src/polyfills/PromiseWithResolvers below other imports allows those modules to execute before the polyfill is installed, which can break test bootstrap in runtimes that do not yet provide Promise.withResolvers natively (the file comment already documents this dependency for Onyx setup). This commit introduced that reordering, so the polyfill should remain the first import in jest/setup.ts to avoid order-dependent initialization failures.

Useful? React with 👍 / 👎.

If tests still pass I think it's fine. But generally it might be right about this.

chuckdries

Very nice!

chuckdries · 2026-02-20T22:50:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-02-20T22:53:09Z

🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-02-20T22:58:18Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #83008.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bec2736-08338eb-dcfabce0c3332c6a8d570fd85d35a211b2ffac88/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bec2736-08338eb-67ab6d4dd02b5bf2e1035bea9eddce420de8fb0b/index.html

Web 🕸️
https://83008.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-02-20T23:02:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-02-24T01:18:59Z

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.3.25-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	cancelled 🔪

roryabraham requested review from a team as code owners February 19, 2026 22:22

melvin-bot bot assigned roryabraham Feb 19, 2026

melvin-bot bot requested a review from parasharrajat February 19, 2026 22:22

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team February 19, 2026 22:22

roryabraham force-pushed the rory-fix-prettier-sorting branch from 0d6ad45 to e0cdb51 Compare February 19, 2026 22:23

roryabraham marked this pull request as draft February 19, 2026 22:27

roryabraham removed the request for review from joekaufmanexpensify February 19, 2026 22:27

roryabraham changed the title ~~[No QA] Fix prettier import sorting broken by @prettier/plugin-oxc~~ [WIP][No QA] Fix prettier import sorting broken by @prettier/plugin-oxc Feb 19, 2026

roryabraham and others added 2 commits February 19, 2026 14:29

Merge main and re-run prettier

598c931

Co-authored-by: Cursor <cursoragent@cursor.com>

roryabraham mentioned this pull request Feb 20, 2026

Support @prettier/plugin-oxc trivago/prettier-plugin-sort-imports#399

Open

roryabraham requested a review from chuckdries February 20, 2026 22:08

roryabraham marked this pull request as ready for review February 20, 2026 22:08

roryabraham changed the title ~~[WIP][No QA] Fix prettier import sorting broken by @prettier/plugin-oxc~~ [No QA] Fix prettier import sorting broken by @prettier/plugin-oxc Feb 20, 2026

roryabraham removed the request for review from parasharrajat February 20, 2026 22:08

chatgpt-codex-connector bot reviewed Feb 20, 2026

View reviewed changes

chuckdries approved these changes Feb 20, 2026

View reviewed changes

chuckdries merged commit bec2736 into main Feb 20, 2026
42 of 45 checks passed

chuckdries deleted the rory-fix-prettier-sorting branch February 20, 2026 22:52

github-actions bot mentioned this pull request Feb 20, 2026

Investigate workflow job failing on main: prettier / Prettier check #83115

Open

OSBotify mentioned this pull request Feb 23, 2026

Deploy Checklist: New Expensify 2026-02-23 #83247

Open

91 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[No QA] Fix prettier import sorting broken by @prettier/plugin-oxc#83008

[No QA] Fix prettier import sorting broken by @prettier/plugin-oxc#83008
chuckdries merged 3 commits intomainfrom
rory-fix-prettier-sorting

roryabraham commented Feb 19, 2026

Uh oh!

melvin-bot bot commented Feb 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 20, 2026

Uh oh!

roryabraham Feb 20, 2026

Uh oh!

chuckdries left a comment

Uh oh!

chuckdries commented Feb 20, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

OSBotify commented Feb 20, 2026

Uh oh!

OSBotify commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

roryabraham commented Feb 19, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 19, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

chuckdries left a comment

Choose a reason for hiding this comment

Uh oh!

chuckdries commented Feb 20, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

OSBotify commented Feb 20, 2026

Uh oh!

OSBotify commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants