Skip to content

Remove Onyx.connect() usage for ONYXKEYS.COLLECTION.POLICY_TAGS in getUpdateMoneyRequestParams function from src/libs/actions/IOU/UpdateMoneyRequest.ts #88302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amyevans merged 11 commits into from
May 4, 2026
Merged

Remove Onyx.connect() usage for ONYXKEYS.COLLECTION.POLICY_TAGS in getUpdateMoneyRequestParams function from src/libs/actions/IOU/UpdateMoneyRequest.ts #88302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
27a1144
initial commit
Guccio163 Apr 8, 2026
b7dd518
Merge branch 'main' of github.com:software-mansion-labs/expensify-app…
Guccio163 Apr 20, 2026
0f3b02c
bring back eslint rule
Guccio163 Apr 20, 2026
9135871
stick to one-level deep PR
Guccio163 Apr 20, 2026
e864ed4
migrate reportPolicyTags one level higher
Guccio163 Apr 21, 2026
6b8efb8
fix comments
Guccio163 Apr 21, 2026
4497748
fix comments
Guccio163 Apr 21, 2026
bef415e
Merge branch 'main' of github.com:software-mansion-labs/expensify-app…
Guccio163 Apr 22, 2026
006b38c
Merge branch 'main' of github.com:software-mansion-labs/expensify-app…
Guccio163 Apr 22, 2026
860a651
Merge branch 'main' of github.com:software-mansion-labs/expensify-app…
Guccio163 Apr 23, 2026
c0df4a0
Merge branch 'main' of github.com:software-mansion-labs/expensify-app…
Guccio163 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libs/actions/IOU/Split.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1585,6 +1585,9 @@ function updateSplitTransactions({
transactionChanges,
policy,
policyTagList: policyTags ?? null,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(transactionIOUReport?.policyID),
policyCategories: policyCategories ?? null,
newTransactionReportID: splitExpense?.reportID,
policyRecentlyUsedCategories,
Expand Down
47 changes: 43 additions & 4 deletions src/libs/actions/IOU/UpdateMoneyRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ function updateMoneyRequestDate({
transactionChanges,
policy,
policyTagList: policyTags,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories,
currentUserAccountIDParam,
currentUserEmailParam,
Expand Down Expand Up @@ -155,6 +158,9 @@ function updateMoneyRequestBillable({
transactionChanges,
policy,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories,
currentUserAccountIDParam,
currentUserEmailParam,
Expand Down Expand Up @@ -202,6 +208,9 @@ function updateMoneyRequestReimbursable({
transactionChanges,
policy,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories,
currentUserAccountIDParam,
currentUserEmailParam,
Expand Down Expand Up @@ -252,6 +261,9 @@ function updateMoneyRequestMerchant({
transactionChanges,
policy,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories,
currentUserAccountIDParam,
currentUserEmailParam,
Expand Down Expand Up @@ -301,6 +313,9 @@ function updateMoneyRequestAttendees({
transactionChanges,
policy,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories,
violations,
currentUserAccountIDParam,
Expand Down Expand Up @@ -354,6 +369,9 @@ function updateMoneyRequestTag({
transactionChanges,
policy,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyRecentlyUsedTags,
policyCategories,
hash,
Expand Down Expand Up @@ -401,6 +419,9 @@ function updateMoneyRequestTaxAmount({
transactionChanges,
policy,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories,
currentUserAccountIDParam,
currentUserEmailParam,
Expand Down Expand Up @@ -454,6 +475,9 @@ function updateMoneyRequestTaxRate({
transactionChanges,
policy,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories,
currentUserAccountIDParam,
currentUserEmailParam,
Expand Down Expand Up @@ -525,6 +549,9 @@ function updateMoneyRequestDistance({
transactionChanges,
policy,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories,
currentUserAccountIDParam,
currentUserEmailParam,
Expand Down Expand Up @@ -625,6 +652,9 @@ function updateMoneyRequestCategory({
transactionChanges,
policy,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories,
policyRecentlyUsedCategories,
currentUserAccountIDParam,
Expand Down Expand Up @@ -678,6 +708,9 @@ function updateMoneyRequestDescription({
transactionChanges,
policy,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories,
currentUserAccountIDParam,
currentUserEmailParam,
Expand Down Expand Up @@ -754,6 +787,9 @@ function updateMoneyRequestDistanceRate({
transactionChanges,
policy,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories,
currentUserAccountIDParam,
currentUserEmailParam,
Expand Down Expand Up @@ -830,7 +866,10 @@ function updateMoneyRequestAmountAndCurrency({
iouReport: parentReport,
transactionChanges,
policy,
policyTagList: policyTagList ?? null,
policyTagList,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
policyCategories: policyCategories ?? null,
allowNegative,
currentUserAccountIDParam,
Expand All @@ -851,6 +890,7 @@ type GetUpdateMoneyRequestParamsType = {
transactionChanges: TransactionChanges;
policy: OnyxEntry<OnyxTypes.Policy>;
policyTagList: OnyxTypes.OnyxInputOrEntry<OnyxTypes.PolicyTagLists>;
reportPolicyTags: OnyxEntry<OnyxTypes.PolicyTagLists>;
policyRecentlyUsedTags?: OnyxEntry<RecentlyUsedTags>;
policyCategories: OnyxTypes.OnyxInputOrEntry<OnyxTypes.PolicyCategories>;
policyRecentlyUsedCategories?: OnyxEntry<OnyxTypes.RecentlyUsedCategories>;
Expand Down Expand Up @@ -890,6 +930,7 @@ function getUpdateMoneyRequestParams(params: GetUpdateMoneyRequestParamsType): U
transactionChanges,
policy,
policyTagList,
reportPolicyTags,
policyRecentlyUsedTags,
policyCategories,
policyRecentlyUsedCategories,
Expand Down Expand Up @@ -1188,9 +1229,7 @@ function getUpdateMoneyRequestParams(params: GetUpdateMoneyRequestParamsType): U
const hasModifiedTag = 'tag' in transactionChanges;
if (hasModifiedTag) {
const optimisticPolicyRecentlyUsedTags = buildOptimisticPolicyRecentlyUsedTags({
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) and getPolicyRecentlyUsedTagsData (https://github.com/Expensify/App/issues/71491) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
policyTags: getPolicyTagsData(iouReport?.policyID),
policyTags: reportPolicyTags ?? {},
policyRecentlyUsedTags,
transactionTags: transactionChanges.tag,
});
Expand Down
4 changes: 4 additions & 0 deletions src/libs/actions/MergeTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import {isDistanceRequest, isTransactionPendingDelete} from '@src/libs/Transacti
import ONYXKEYS from '@src/ONYXKEYS';
import ROUTES from '@src/ROUTES';
import type {CardList, MergeTransaction, Policy, PolicyCategories, PolicyTagLists, Report, ReportNextStepDeprecated, Transaction, TransactionViolations} from '@src/types/onyx';
import {getPolicyTagsData} from './IOU';
import type {UpdateMoneyRequestData} from './IOU';
import {getCleanUpTransactionThreadReportOnyxData} from './IOU/DeleteMoneyRequest';
import {getDeleteTrackExpenseInformation} from './IOU/TrackExpense';
Expand Down Expand Up @@ -271,6 +272,9 @@ function getOnyxTargetTransactionData({
transactionChanges: filteredTransactionChanges,
policy,
policyTagList: policyTags,
// TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
// eslint-disable-next-line @typescript-eslint/no-deprecated
reportPolicyTags: getPolicyTagsData(targetTransactionThreadParentReport?.policyID),
policyCategories,
violations: targetTransactionViolations ?? [],
shouldBuildOptimisticModifiedExpenseReportAction,
Expand Down
Loading
Loading