Use ActivityIndicator instead of FullscreenLoadingIndicator in SetDefaultWorkspacePage#88740
Draft
Use ActivityIndicator instead of FullscreenLoadingIndicator in SetDefaultWorkspacePage#88740
Conversation
…ltWorkspacePage Replace FullscreenLoadingIndicator with a View-wrapped ActivityIndicator to avoid showing a duplicate back button when shouldUseGoBackButton is enabled by default. The wrapping View provides the same layout and background styling (flex1 + fullScreenLoading) matching the codebase convention used in similar pages. Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Replace
FullscreenLoadingIndicatorwith aView-wrappedActivityIndicatorinSetDefaultWorkspacePage. This prevents a duplicate back button from appearing whenshouldUseGoBackButtonis enabled by default inFullscreenLoadingIndicator(since the page already has aHeaderWithBackButton). The wrappingViewprovides the same layout and background styling (flex1+fullScreenLoading), matching the established codebase pattern used in similar pages likeReportChangeWorkspacePage.Fixed Issues
$ #85386
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
// TODO: The human co-author must fill out offline tests before marking this PR as "ready for review"
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari