Skip to content

Fix bulk Pay/Mark as Paid disappearing for whole-report selections#94075

Draft
MelvinBot wants to merge 1 commit into
mainfrom
claude-bulkPayMarkAsPaidPolicyIDs
Draft

Fix bulk Pay/Mark as Paid disappearing for whole-report selections#94075
MelvinBot wants to merge 1 commit into
mainfrom
claude-bulkPayMarkAsPaidPolicyIDs

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

When multiple whole reports are selected in the Search/Reports view, the bulk action menu intermittently dropped both Pay and Mark as Paid, leaving only Export — even when the selected reports shared the same currency and month.

Root cause: selectedPolicyIDs was derived only from selectedTransactions, never from selectedReports. When the user selects whole reports (no individual transaction rows), selectedTransactions is empty, so selectedPolicyIDs was empty and selectedPolicyID was undefined. useBulkPayOptions short-circuits to bulkPayButtonOptions = undefined when selectedPolicyID is missing, and the menu gate … && !!bulkPayButtonOptions?.length then removed the entire Pay group — including its Mark as Paid submenu item. (selectedReportID already falls back to selectedReportIDs, but selectedPolicyID did not — this gap was introduced alongside the cross-workspace bulk-pay change in #87148.)

The fix derives selectedPolicyIDs from selectedReports as well as selectedTransactions, so whole-report selections produce a valid selectedPolicyID and useBulkPayOptions can build the native Pay options (and, for multi-currency selections, the Mark as Paid / Pay Elsewhere fallback) instead of returning undefined.

This implements item 2 of the approved proposal — the regression that explains the dominant reported symptom (options disappearing even for same-currency/same-month selections). Proposal items 1 (offering a standalone Mark as Paid that is fully decoupled from the native Pay submenu) and 3 (degrading rather than removing the group when one selected report has canPay === false) change bulk-pay eligibility semantics and warrant dedicated multi-workspace QA, so they are intentionally left out of this PR and called out as follow-ups for the reviewer.

🤖 This is a Melvin-authored draft. eVoloshchak should review the change, complete the Tests/QA sections, and mark it "Ready for review" once validated.

Fixed Issues

$ #93699
PROPOSAL: #93699 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  1. Open Search → Reports (Expenses) with reports across one or more workspaces that you can pay.
  2. Select multiple whole reports (use the row checkboxes, not individual transactions) that share the same currency and month.
  3. Verify the bulk action menu offers Pay and Mark as Paid (not only Export).
  4. Repeat with reports spanning multiple currencies and verify Mark as Paid remains available.
  • Verify that no errors appear in the JS console

Offline tests

  • Verify that no errors appear in the JS console

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…s Paid options appear for whole-report selections

Co-authored-by: Eugene Voloshchak <eVoloshchak@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team June 19, 2026 16:50
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-bulkPayMarkAsPaidPolicyIDs
git checkout -b claude-bulkPayMarkAsPaidPolicyIDs upstream/claude-bulkPayMarkAsPaidPolicyIDs
git push -u origin claude-bulkPayMarkAsPaidPolicyIDs

Then you can close this PR and open a new one from your fork.

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/hooks/useSearchBulkActions.ts 55.28% <100.00%> (-0.06%) ⬇️
... and 26 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants