[PoC] Onyx GET asynchronous by LukasMod · Pull Request #99667 · Expensify/App

LukasMod · 2026-08-27T13:04:45Z

Explanation of Change

Ship Onyx.get() as a public asynchronous read in react-native-onyx.
- Expose Onyx.get<TKey>(key: TKey): Promise<OnyxValue<TKey>> on the public Onyx object, exported from lib/index.ts.
- Implement it on top of OnyxUtils.tryGetCachedValue wrapped in OnyxUtils.afterInit. That is the same read useOnyx performs, and unlike the internal OnyxUtils.get it can return a whole collection. No new storage machinery is needed today.
- Make the return type a Promise so a component cannot directly await it during render. This is the built-in guard; lint still blocks Onyx.get(...).then(...) and use(Onyx.get(...)) inside components.
Define where Onyx.get may be called.
- Allowed: event handlers, network callbacks, action creators and library helpers that return void or Promise<void>.
- Allowed: lifecycle helpers such as runAfterTransitions callbacks, which are deferred and not on the render path.
- Not allowed: component render bodies, JSX-returning helpers, selectors, useMemo/useCallback bodies, module scope, or any code whose return value is consumed synchronously by rendered output.
- Not allowed: synchronous optimistic builders that return an Onyx.update payload. These keep receiving data through parameters.

react native onyx PR: Expensify/react-native-onyx#831

Fixed Issues

$
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-08-27T13:04:57Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

LukasMod · 2026-08-27T13:24:45Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 148d4d6d84

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

LukasMod · 2026-08-28T08:27:15Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 536510c2d3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

LukasMod · 2026-08-28T08:46:22Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1ee9f2ab75

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

LukasMod · 2026-08-28T09:17:48Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cea1ebbf15

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

LukasMod · 2026-08-28T09:38:07Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 43482ca165

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

LukasMod · 2026-08-28T10:31:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7fe01ba7c5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

LukasMod · 2026-08-28T10:48:54Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4350bc376

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-08-28T13:01:54Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/runtimeDefaults.ts	`100.00% <100.00%> (ø)`
src/hooks/useOnyx.ts	`90.00% <100.00%> (ø)`
src/libs/OnyxUtils/index.ts	`100.00% <100.00%> (ø)`
src/libs/actions/OnyxDerived/index.ts	`97.67% <ø> (ø)`
...migrations/MoveFilesOutOfDocuments/index.native.ts	`100.00% <ø> (ø)`
src/setup/addUtilsToWindow.ts	`16.43% <ø> (-0.02%)`	⬇️
... and 82 files with indirect coverage changes

…tion guard

LukasMod · 2026-08-28T13:30:49Z

@codex review

LukasMod · 2026-08-28T13:43:27Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 970ef20b8c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

LukasMod · 2026-08-28T13:58:41Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d136d11c25

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-28T14:03:17Z

+    if (parent?.type === 'CallExpression') {
+        if (parent.callee === functionNode) {
+            return SYNCHRONOUS;


Unwrap typed callbacks before classifying hook execution

When a render-time callback is wrapped in a TypeScript expression, such as useMemo((() => OnyxUtils.get(key)) as () => Promise<Value>, []), the function's immediate parent is a TSAsExpression, so this CallExpression branch is skipped. The callback then falls through to DEFERRED, causing the read to be treated as event-time even though useMemo executes it during render; unwrap transparent TypeScript assertion, non-null, and satisfies nodes before checking the callback's containing call.

Useful? React with 👍 / 👎.

melvin-bot Bot assigned LukasMod Aug 27, 2026

chatgpt-codex-connector Bot reviewed Aug 27, 2026

View reviewed changes

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js Outdated

LukasMod added 6 commits August 28, 2026 09:29

Use onyx get async

30eab14

clean up

a2ebeb4

prettier fix

d69c96b

narrow typescript type instead of lint forbiddenKeys rule

19bb35e

remove tracking script

a9f344d

clean up

4826d22

LukasMod force-pushed the feat/onyx-get-async branch from 148d4d6 to 4826d22 Compare August 28, 2026 07:39

LukasMod added 2 commits August 28, 2026 10:19

clean up

061a789

update rule

536510c

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js

fix no-unsafe-onyx-read rule

1ee9f2a

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js Outdated

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js Outdated

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js Outdated

LukasMod added 2 commits August 28, 2026 11:02

fix no-unsafe-onyx-read rule

9bcd3f9

update rule

cea1ebb

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js

update rule

43482ca

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js Outdated

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js Outdated

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js Outdated

LukasMod added 2 commits August 28, 2026 12:28

update rule

cb6f364

fmt fix

7fe01ba

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js Outdated

update rule

d4350bc

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js Outdated

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js Outdated

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js Outdated

Use ReadonlyDeep for await Onyx.get

23231fe

Type OnyxUtils.get consistently with useOnyx and stop claiming a muta…

970ef20

…tion guard

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Comment thread package-lock.json Outdated

Comment thread eslint-plugin-local-rules/no-unsafe-onyx-read.js

LukasMod mentioned this pull request Aug 28, 2026

Add public Onyx.get Expensify/react-native-onyx#831

Draft

42 tasks

update rule and lock

d136d11

chatgpt-codex-connector Bot reviewed Aug 28, 2026

View reviewed changes

Uh oh!

Conversation

LukasMod commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Aug 27, 2026

Uh oh!

LukasMod commented Aug 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

LukasMod commented Aug 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

LukasMod commented Aug 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LukasMod commented Aug 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

LukasMod commented Aug 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LukasMod commented Aug 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

LukasMod commented Aug 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Aug 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

LukasMod commented Aug 28, 2026

Uh oh!

LukasMod commented Aug 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

LukasMod commented Aug 27, 2026 •

edited

Loading

codecov Bot commented Aug 28, 2026 •

edited by github-actions Bot

Loading