Skip to content

[No QA] Update Explore-whats-changed-in-New-Expensify.md - #99690

Open
brianlee-expensify wants to merge 2 commits into
mainfrom
brianlee-expensify-patch-6
Open

[No QA] Update Explore-whats-changed-in-New-Expensify.md#99690
brianlee-expensify wants to merge 2 commits into
mainfrom
brianlee-expensify-patch-6

Conversation

@brianlee-expensify

Copy link
Copy Markdown
Contributor

added link to training webinars

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

added link to training webinars
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This is a small, low-risk content change to Explore-whats-changed-in-New-Expensify.md. It converts two inline "Coming from Expensify Classic" links into a bulleted list for better scannability, and adds one new sentence pointing members to a live training webinar (registration and on-demand recordings). The change touches only the introductory paragraph and does not alter headings, metadata, or workflow structure.

Scores Summary

  • Readability: 9/10 - Breaking the two Classic-mapping links out of a run-on sentence into a bulleted list genuinely improves scannability. The new webinar sentence is clear and benefit-oriented.
  • AI Readiness: 8/10 - No structural regressions: single top-level title preserved, task-based ## headings untouched, and rich YAML metadata (including internalScope) is intact. The added link points to a training resource that is slightly tangential to this article's stated scope, but it is reasonable supporting context.
  • Style Compliance: 5/10 - One clear violation: the new link uses a full absolute URL (https://help.expensify.com/articles/...) instead of a relative link. HELP_AUTHORING_GUIDELINES.md Section 7 (Link Formatting) requires relative links only and explicitly prohibits full URLs. The existing Classic links in this same paragraph correctly use relative paths, so this is inconsistent.

Key Findings

  • Must fix (Style): The webinar link is a full URL. Per Section 7 it must be relative, e.g. [...](/articles/new-expensify/getting-started/How-to-Access-Expensify-Training). The two adjacent Classic links already follow this pattern.
  • Anchor text (Style/AI): The anchor is just the single word register. HELP_AUTHORING_GUIDELINES.md Anchor Text Rules discourage vague anchors and recommend descriptive, search-aligned phrasing such as "register for a live Expensify training webinar" or "learn how to access Expensify Training." Consider making the linked text more descriptive.
  • Positive: Converting the inline links to a bulleted list is a genuine readability improvement and aligns with the scannable-formatting intent of the authoring guidelines.
  • Positive: No heading, metadata, or single-workflow rules were broken; the change stays within the article's existing scope.
  • Minor: A trailing period was left on the second bullet's link line — cosmetic only.

Recommendations

  1. Convert the new webinar link from a full URL to a relative link (required by Section 7).
  2. Replace the bare register anchor with descriptive, search-aligned anchor text.
  3. Optionally remove the stray trailing period after the second bullet for consistency.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Transitioning-to-New-Expensify/Explore-whats-changed-in-New-Expensify.md — Readability improved; one required fix (absolute URL) and one recommended fix (anchor text) before merge.

Note: Detailed line-by-line feedback has been provided as inline comments.

@github-actions github-actions Bot changed the title Update Explore-whats-changed-in-New-Expensify.md [No QA] Update Explore-whats-changed-in-New-Expensify.md Aug 27, 2026
@OSBotify

This comment has been minimized.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://191a6546.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants