[Hold Auth#99695 Web-E#55719] Render the over limit approver and approval limit policy change logs report actions

[rayane-d]

Explanation of Change

In Workflows, an admin can add a second approver for reports above a set amount. For example, reports over $100 also need Someone's approval. BE now posts a message in #admins when that approver or that amount changes, using two new report actions.

This PR renders them in NewDot.

New action	Fires when
POLICYCHANGELOG_UPDATE_OVER_LIMIT_FORWARDS_TO	the approver is set, changed, or removed
POLICYCHANGELOG_UPDATE_APPROVAL_LIMIT	only the amount changed

• set the approval workflow for approver@test.com to forward reports over $100.00 to second-approver@test.com
• changed the approval workflow for approver@test.com to forward reports over $200.00 (previously $100.00)
• changed the approval workflow for approver@test.com to forward reports over $200.00 to new-second-approver@test.com (previously forwarded to second-approver@test.com)
• changed the approval workflow for approver@test.com to forward reports over $300.00 to second-approver@test.com (previously forwarded reports over $200.00 to new-second-approver@test.com)
• changed the approval workflow for approver@test.com to stop forwarding reports over $300.00 (previously forwarded to second-approver@test.com)

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/668648
PROPOSAL:

Tests

1. Create a Control workspace
2. invite member@test.com, approver@test.com, second-approver@test.com, and new-second-approver@test.com as members.
3. Open the workspace, go to Workflows, and turn on Add approvals.
4. Create a workflow for member@test.com and add approver@test.com as the approver
5. Open the workflow that contains member@test.com.
6. Open the approver row. Set Report amount to 100 and Additional approver to second-approver@test.com. Save.
7. Confirm the approver row shows the hint Reports above $100.00 forward to second-approver@test.com.
8. Open the workspace #admins room. Confirm the newest message is:
   set the approval workflow for approver@test.com to forward reports over $100.00 to second-approver@test.com
9. Reopen the approver row, change Report amount to 200, and save. Confirm the newest message
   is:
   changed the approval workflow for approver@test.com to forward reports over $200.00 (previously $100.00)
10. Reopen the approver row, change Additional approver to new-second-approver@test.com, and save. Confirm the newest message is:
    changed the approval workflow for approver@test.com to forward reports over $200.00 to new-second-approver@test.com (previously forwarded to second-approver@test.com)
11. Reopen the approver row, set Report amount to 300 and Additional approver to
    second-approver@test.com in one save. Confirm exactly one message is added:
    changed the approval workflow for approver@test.com to forward reports over $300.00 to second-approver@test.com (previously forwarded reports over $200.00 to new-second-approver@test.com)
12. Reopen the approver row, choose Remove limit, and save. Confirm the newest message is:
    changed the approval workflow for approver@test.com to stop forwarding reports over $300.00 (previously forwarded to second-approver@test.com)

Screen.Recording.2026-08-28.at.9.08.30.PM.mov

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

[jamesdeanexpensify]

• changed the approval workflow for approver@test.com to forward reports over $100.00 to second-approver@test.com

  • Question - what specific change actually triggered this? Was there previously a different second-approver, or something else?

• changed the approval workflow for approver@test.com to stop forwarding reports over the $300.00 limit (previously forwarded to second-approver@test.com)

  • See two edits above

The rest look good!

[rayane-d]

• changed the approval workflow for approver@test.com to forward reports over $100.00 to second-approver@test.com

  • Question - what specific change actually triggered this? Was there previously a different second-approver, or something else?

This fires the first time an over-limit approver is set for that approver. In this case the admin set "Report amount" to "$100.00" and "Additional approver" to "second-approver@test.com" on "approver@test.com"'s row, and neither field had a value before. There was no previous second approver.

[jamesdeanexpensify]

Ohh if this is the first time, then I wonder if we should use set instead of changed then. @MelvinBot does that sound accurate and match other system messages?

[MelvinBot]

Yes — set is accurate for that first message, and it matches the dominant convention in workspaceActions. But it should be conditional, not a blanket rename: that string is also used when the approver does change.

Suggested copy

• First time (no previous over-limit approver): set the approval workflow for member@test.com to forward reports over $100.00 to second-approver@test.com
• Any later change: keep changed the approval workflow for ... (previously ...)

The closest precedent is changedInvoiceCompanyName, which does exactly this — changed ... (previously ...) when there's an old value, set ... when there isn't. Same set on first write / changed ... (previously ...) pairing shows up in setAutoPayApprovedReportsLimit, setReceiptRequiredAmount, setMaxExpenseAmount, and setMaxExpenseAge.

The one caveat: the sibling approval-workflow messages say changed the approval workflow ... even with no previous value — changedSubmitsToApprover and changedForwardsTo. I'd argue those are different: a member always had some approver, and changedForwardsTo explicitly names the prior state (previously final approved reports). Over-limit forwarding has no implicit prior state — nothing was forwarding before — so set is the more accurate verb here.

Why the branch is safe to key on

getOverLimitForwardsToUpdateMessage leaves previousApprover undefined only when previousOverLimitForwardsTo is absent, which is the first-time case. So:

changedOverLimitForwardsTo: ({member, approver, limit, previousApprover, previousLimit}) => {
    if (!previousApprover) {
        return `set the approval workflow for ${member} to forward reports over ${limit} to ${approver}`;
    }
    let text = `changed the approval workflow for ${member} to forward reports over ${limit} to ${approver}`;
    text += previousLimit ? ` (previously forwarded reports over ${previousLimit} to ${previousApprover})` : ` (previously forwarded to ${previousApprover})`;
    return text;
},

changedApprovalLimit and removedOverLimitForwardsTo always have a prior state, so they don't need a set variant.

---

view run

[jamesdeanexpensify]

@rayane-d then I think we should do this:

changed set the approval workflow for approver@test.com to forward reports over $100.00 to second-approver@test.com

[rayane-d]

Thanks for the review! I've updated the copy accordingly.