-
Notifications
You must be signed in to change notification settings - Fork 4k
Anchor the validate code countdown to the wall clock #99728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mukhrr
wants to merge
3
commits into
Expensify:main
Choose a base branch
from
mukhrr:fix/99191
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+125
−12
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| import {act, render, screen} from '@testing-library/react-native'; | ||
|
|
||
| import ValidateCodeCountdown from '@components/ValidateCodeCountdown'; | ||
| import type {ValidateCodeCountdownHandle} from '@components/ValidateCodeCountdown/types'; | ||
|
|
||
| import CONST from '@src/CONST'; | ||
|
|
||
| import type ReactNative from 'react-native'; | ||
|
|
||
| import React, {createRef} from 'react'; | ||
|
|
||
| jest.mock('@hooks/useLocalize', () => | ||
| jest.fn(() => ({ | ||
| translate: (key: string, params?: {timeRemaining?: string}) => params?.timeRemaining ?? key, | ||
| })), | ||
| ); | ||
| jest.mock('@hooks/useAccessibilityAnnouncement', () => jest.fn()); | ||
| jest.mock('@components/RenderHTML', () => { | ||
| const ReactMock = jest.requireActual<typeof React>('react'); | ||
| const {Text} = jest.requireActual<typeof ReactNative>('react-native'); | ||
|
|
||
| return ({html}: {html: string}) => ReactMock.createElement(Text, null, html.replaceAll(/<[^>]*>/g, '')); | ||
| }); | ||
|
|
||
| const BASE_TIME = new Date('2026-08-21T10:00:00.000Z').valueOf(); | ||
|
|
||
| // One act per tick so React commits the effect that schedules the next one. | ||
| function tickSeconds(seconds: number) { | ||
| for (let i = 0; i < seconds; i++) { | ||
| act(() => jest.advanceTimersByTime(CONST.MILLISECONDS_PER_SECOND)); | ||
| } | ||
| } | ||
|
|
||
| // Clock advances with no callback delivered, the way a throttled tab or a backgrounded app behaves. | ||
| function suspendFor(milliseconds: number) { | ||
| act(() => { | ||
| jest.setSystemTime(Date.now() + milliseconds); | ||
| jest.advanceTimersByTime(CONST.MILLISECONDS_PER_SECOND); | ||
| }); | ||
| } | ||
|
|
||
| function renderCountdown(onCountdownFinish: () => void = jest.fn(), requestedAt?: number) { | ||
| const ref = createRef<ValidateCodeCountdownHandle>(); | ||
| render( | ||
| <ValidateCodeCountdown | ||
| ref={ref} | ||
| requestedAt={requestedAt} | ||
| onCountdownFinish={onCountdownFinish} | ||
| />, | ||
| ); | ||
| return ref; | ||
| } | ||
|
|
||
| describe('ValidateCodeCountdown', () => { | ||
| beforeEach(() => { | ||
| jest.useFakeTimers(); | ||
| jest.setSystemTime(BASE_TIME); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| jest.useRealTimers(); | ||
| }); | ||
|
|
||
| it('reports the time that actually elapsed after the timer was starved of callbacks', () => { | ||
| renderCountdown(); | ||
| expect(screen.getByText('00:30')).toBeOnTheScreen(); | ||
|
|
||
| tickSeconds(3); | ||
| expect(screen.getByText('00:27')).toBeOnTheScreen(); | ||
|
|
||
| // 14s of the 30s window are gone once the single resume callback lands. | ||
| suspendFor(10 * CONST.MILLISECONDS_PER_SECOND); | ||
| expect(screen.getByText('00:16')).toBeOnTheScreen(); | ||
| }); | ||
|
|
||
| it('finishes once the window has elapsed even if the callbacks never arrived', () => { | ||
| const onCountdownFinish = jest.fn(); | ||
| renderCountdown(onCountdownFinish); | ||
|
|
||
| suspendFor(CONST.REQUEST_CODE_DELAY * CONST.MILLISECONDS_PER_SECOND); | ||
| expect(onCountdownFinish).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('keeps measuring from a persisted requestedAt when one is passed', () => { | ||
| renderCountdown(jest.fn(), BASE_TIME - 8 * CONST.MILLISECONDS_PER_SECOND); | ||
| expect(screen.getByText('00:22')).toBeOnTheScreen(); | ||
|
|
||
| suspendFor(10 * CONST.MILLISECONDS_PER_SECOND); | ||
| expect(screen.getByText('00:11')).toBeOnTheScreen(); | ||
| }); | ||
|
|
||
| it('measures from the resend time after the countdown is reset', () => { | ||
| const ref = renderCountdown(); | ||
|
|
||
| tickSeconds(5); | ||
| act(() => ref.current?.resetCountdown()); | ||
| expect(screen.getByText('00:30')).toBeOnTheScreen(); | ||
|
|
||
| suspendFor(10 * CONST.MILLISECONDS_PER_SECOND); | ||
| expect(screen.getByText('00:19')).toBeOnTheScreen(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.