Skip to content

chore(deps): pin @types/vscode to engines.vscode via dependabot ignore - #91

Open
FROWNINGdev wants to merge 1 commit into
mainfrom
chore/dependabot-ignore-types-vscode
Open

chore(deps): pin @types/vscode to engines.vscode via dependabot ignore#91
FROWNINGdev wants to merge 1 commit into
mainfrom
chore/dependabot-ignore-types-vscode

Conversation

@FROWNINGdev

@FROWNINGdev FROWNINGdev commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Problem

Dependabot PR #89 (@types/vscode 1.125.0 → 1.134.0) fails the build job:

##[error] @types/vscode ^1.134.0 greater than engines.vscode ^1.85.0.
Either upgrade engines.vscode or use an older @types/vscode version

vsce package treats @types/vscode as a declaration of the minimum API surface the extension compiles against, so it must never exceed engines.vscode.

Why not just bump engines.vscode

That would make the extension uninstallable on every VS Code older than 1.134 — a real compatibility loss traded for a dev-only type package. The types are the side that should stay pinned.

Change

Add @types/vscode to the npm ignore: list in .github/dependabot.yml, with no update-types filter, so all version updates are held. It now moves only by hand, in the same commit that raises engines.vscode.

Follows the existing precedent in this file (typescript majors, python base-image minors).

Follow-up

PR #89 is closed as won't-fix — Dependabot will not reopen it once this lands.

Summary by CodeRabbit

  • Chores
    • Automated dependency updates for VS Code type definitions are now paused, requiring manual review for compatibility with the supported VS Code version.

vsce refuses to package the extension when @types/vscode outruns the
engine declared in package.json:

    @types/vscode ^1.134.0 greater than engines.vscode ^1.85.0.
    Either upgrade engines.vscode or use an older @types/vscode version

That is what turned the `build` job red on PR #89 (1.125.0 -> 1.134.0).
Raising engines.vscode to match would silently drop every user on an
older VS Code, so the types are the side that has to stay pinned.

Ignore all version updates for @types/vscode. It now moves only by hand,
in the same commit that raises engines.vscode.
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 25c4499b-4334-4a04-bc87-11b02071d3e0

📥 Commits

Reviewing files that changed from the base of the PR and between 738230e and 5dc33cc.

📒 Files selected for processing (1)
  • .github/dependabot.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Dependabot now ignores @types/vscode updates in the npm configuration. This keeps VS Code type definition updates under manual coordination with the declared VS Code engine version.

Changes

Dependabot configuration

Layer / File(s) Summary
Ignore VS Code type updates
.github/dependabot.yml
Dependabot ignores automatic updates to @types/vscode.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 5dc33

This localized change keeps the development type package aligned with the supported VS Code engine range; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the Dependabot ignore change for @types/vscode and its coordination with engines.vscode.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/dependabot-ignore-types-vscode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant