chore(deps): pin @types/vscode to engines.vscode via dependabot ignore - #91
chore(deps): pin @types/vscode to engines.vscode via dependabot ignore#91FROWNINGdev wants to merge 1 commit into
Conversation
vsce refuses to package the extension when @types/vscode outruns the
engine declared in package.json:
@types/vscode ^1.134.0 greater than engines.vscode ^1.85.0.
Either upgrade engines.vscode or use an older @types/vscode version
That is what turned the `build` job red on PR #89 (1.125.0 -> 1.134.0).
Raising engines.vscode to match would silently drop every user on an
older VS Code, so the types are the side that has to stay pinned.
Ignore all version updates for @types/vscode. It now moves only by hand,
in the same commit that raises engines.vscode.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughDependabot now ignores ChangesDependabot configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change keeps the development type package aligned with the supported VS Code engine range; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Dependabot PR #89 (
@types/vscode1.125.0 → 1.134.0) fails thebuildjob:vsce packagetreats@types/vscodeas a declaration of the minimum API surface the extension compiles against, so it must never exceedengines.vscode.Why not just bump
engines.vscodeThat would make the extension uninstallable on every VS Code older than 1.134 — a real compatibility loss traded for a dev-only type package. The types are the side that should stay pinned.
Change
Add
@types/vscodeto the npmignore:list in.github/dependabot.yml, with noupdate-typesfilter, so all version updates are held. It now moves only by hand, in the same commit that raisesengines.vscode.Follows the existing precedent in this file (
typescriptmajors,pythonbase-image minors).Follow-up
PR #89 is closed as won't-fix — Dependabot will not reopen it once this lands.
Summary by CodeRabbit