feat(cli): add artifact version and chunk digests to the handoff wire contract - #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Version negotiation and content addressing for pack artifacts, the seam the droid transfer protocol consumes:
vfs version --jsongainsartifactVersion,minSupportedArtifactVersion, andfeatures.adopt.vfs pack --jsongainsartifactVersion,chunkSizeBytes, andchunks: [{index, sizeBytes, sha256}], computed at--chunk-sizegranularity (default 4 MiB).adoptrefuses artifacts newer than it supports with a distinct error, so a receiver behind on vfs fails the preflight instead of corrupting state.Why
The transfer protocol (factory-mono AC-768 stack) is content-addressed and resumable: per-chunk digests let the receiver verify chunks independently, ingest them out of order, and resume across daemon restarts. The version fields let sender and receiver negotiate before any bytes move.
Testing
fmt / clippy / unit tests green. Full
gate.shon this tip: 24 PASS / 0 FAIL / 1 host-kernel skip (FUSE-over-io_uring).Stacked on the adopt PR; merge that first.